Skip to content

external aws account check! endpoint #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tvdaptible merged 15 commits into from
Dec 18, 2025
Merged

external aws account check! endpoint #208

tvdaptible merged 15 commits into from
Dec 18, 2025

Conversation

@tvdaptible
Copy link
Contributor

@tvdaptible tvdaptible commented Dec 11, 2025 •
edited
Loading

  • ensure backend supports the api call

@snyk-io
Copy link

snyk-io bot commented Dec 11, 2025 •
edited
Loading

✅ Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
✅ Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@tvdaptible tvdaptible mentioned this pull request Dec 11, 2025
Merged
1 task
@tvdaptible
lint roller
8299f5a
@tvdaptible
rm bundler version from ci.yml
fde0984 
to match aptible/aptible-auth-ruby#82
@tvdaptible
Revert "rm bundler version from ci.yml"
789b466 
This reverts commit fde0984.

ruby versions 2.1 - 2... don't work without the earlier bundler. womp womp
@tvdaptible
Struct does not support keyword init args until ruby 2.5, so use simp…
e8ab5da 
…le classes instead
@tvdaptible
ensure tests work even if APTIBLE_API_ROOT_URL env var is set
a118e0a
@tvdaptible
does this make ci happy?
b7a7925
@tvdaptible
it did not
51b1452
@tvdaptible
ok maybe this will fix ci 🤞
8fe6db7
@tvdaptible
Merge branch 'master' of https://github.com/aptible/aptible-api-ruby …
d0ca63b 
…into ext-aws-check
@tvdaptible
we do not support 2.1 and 2.2 anymore...
c746b63
@tvdaptible
bump version 1.10.1 --> 1.11.0
0367fdc
@tvdaptible
Merge branch 'master' of https://github.com/aptible/aptible-api-ruby …
b15b98a 
…into ext-aws-check
@tvdaptible
chore: use bundler 2.x with ruby 2.7
a993c06 
this seems to be a known issue: https://gitlab.com/gitlab-org/gitlab/-/issues/337510
@tvdaptible
Merge branch 'master' of https://github.com/aptible/aptible-api-ruby …
458910c 
…into ext-aws-check
@tvdaptible tvdaptible marked this pull request as ready for review December 18, 2025 01:10
@tvdaptible tvdaptible requested a review from almathew as a code owner December 18, 2025 01:10
madhuravius
madhuravius approved these changes Dec 18, 2025
View reviewed changes
Copy link
Member

@madhuravius madhuravius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, slightly breaks from the pairing of model <--> resource, but this is a different response type than a conventional model

@tvdaptible tvdaptible merged commit a6e0eeb into master Dec 18, 2025
15 checks passed
@tvdaptible tvdaptible deleted the ext-aws-check branch December 18, 2025 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@madhuravius madhuravius madhuravius approved these changes

@almathew almathew Awaiting requested review from almathew almathew is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tvdaptible @madhuravius