chore: test ruby 2.3 thru 3.4 [SC-35314] #211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
tvdaptible
changed the title
tvdaptible
changed the title
almathew
approved these changes
Dec 16, 2025
madhuravius
approved these changes
Dec 16, 2025
Member
madhuravius
left a comment
madhuravius
left a comment
There was a problem hiding this comment.
LGTM - we MIGHT want multiple docker-compose.yml runners locally to test different versions locally but that's a huge overoptimization
Contributor
Author
what doesn't work locally? make lint test RUBY_VERSION=2.3
make lint test RUBY_VERSION=2.4
make lint test RUBY_VERSION=2.7
make lint test RUBY_VERSION=3.3
make lint test RUBY_VERSION=3.4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2.7 was failing due to using the older version of activesupport, which is also fixed in this pr.
also add
make test RUBY_VERSION=X.Yandmake lint RUBY_VERSION=X.Yto make it simple to repro issues locally