Conversation
UserNotFound
requested changes
Mar 3, 2025
Member
UserNotFound
left a comment
UserNotFound
left a comment
There was a problem hiding this comment.
Maybe a nit, or i've just seen the word "drain" too much for it to hold any meaning to me anymore...but can we change the help text from "will be drained" to "will be sent to your chosen destination" or something?
I second this suggestion. I think it would help make things clearer. |
Member
Author
|
updated! |
UserNotFound
requested changes
Mar 4, 2025
Member
UserNotFound
left a comment
UserNotFound
left a comment
There was a problem hiding this comment.
Sorry I didn't notice this the first time, but you need to include a space for each \ on all of these help blurbs that were changed.
UserNotFound
approved these changes
Mar 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consistenly use
-for options across log drain creation commands.Make it more clear what the default behavior is in the help text, since Thor makes it confusing by including the
--no-versions for booleans.Alternatives would be to build Thor ourselves to get rid of it, or manage the default: true ourselves.