Skip to content

Skip failing parts of PITR tests #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bryanmikaptible merged 1 commit into from
Feb 27, 2026
Merged

Skip failing parts of PITR tests #169

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 14 additions & 11 deletions aptible/resource_database_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,8 @@ func TestAccResourceDatabase_withoutBackups(t *testing.T) {
resource.TestCheckResourceAttr("aptible_database.test", "container_profile", "m5"),
resource.TestCheckResourceAttr("aptible_database.test", "iops", "3000"),
resource.TestCheckResourceAttr("aptible_database.test", "disk_size", "10"),
resource.TestCheckResourceAttr("aptible_database.test", "enable_backups", "false"),
// TEMPORARILY DISABLED - PITR must be disabled before backups can be disabled
// resource.TestCheckResourceAttr("aptible_database.test", "enable_backups", "false"),
resource.TestCheckResourceAttrSet("aptible_database.test", "database_id"),
resource.TestCheckResourceAttrSet("aptible_database.test", "database_image_id"),
resource.TestMatchResourceAttr("aptible_database.test", "default_connection_url", regexp.MustCompile(`postgresql://.*@db-.*`)),
Expand Down Expand Up @@ -195,16 +196,17 @@ func TestAccResourceDatabase_update(t *testing.T) {
ImportState: true,
ImportStateVerify: true,
},
{
Config: testAccAptibleDatabaseUpdate(env.ID, dbHandle),
Check: resource.ComposeTestCheckFunc(
resource.TestCheckResourceAttr("aptible_database.test", "container_size", "512"),
resource.TestCheckResourceAttr("aptible_database.test", "container_profile", "r5"),
resource.TestCheckResourceAttr("aptible_database.test", "iops", "4000"),
resource.TestCheckResourceAttr("aptible_database.test", "enable_backups", "false"),
resource.TestCheckResourceAttr("aptible_database.test", "disk_size", "20"),
),
},
// TEMPORARILY DISABLED - Step 3: PITR must be disabled before backups can be disabled
// {
// Config: testAccAptibleDatabaseUpdate(env.ID, dbHandle),
// Check: resource.ComposeTestCheckFunc(
// resource.TestCheckResourceAttr("aptible_database.test", "container_size", "512"),
// resource.TestCheckResourceAttr("aptible_database.test", "container_profile", "r5"),
// resource.TestCheckResourceAttr("aptible_database.test", "iops", "4000"),
// resource.TestCheckResourceAttr("aptible_database.test", "enable_backups", "false"),
// resource.TestCheckResourceAttr("aptible_database.test", "disk_size", "20"),
// ),
// },
},
})
})
Expand Down Expand Up @@ -345,6 +347,7 @@ func testAccAptibleDatabaseVersion(envId int64, dbHandle string) string {
`, envId, dbHandle)
}

//nolint:unused // Will be re-enabled once PITR bug is fixed
func testAccAptibleDatabaseUpdate(envId int64, dbHandle string) string {
return fmt.Sprintf(`
resource "aptible_database" "test" {
Expand Down
25 changes: 14 additions & 11 deletions aptible/resource_replica_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,8 @@ func TestAccResourceReplica_withoutBackups(t *testing.T) {
resource.TestCheckResourceAttr("aptible_replica.test", "iops", "3000"),
resource.TestCheckResourceAttr("aptible_replica.test", "container_profile", "m5"),
resource.TestCheckResourceAttr("aptible_replica.test", "disk_size", "10"),
resource.TestCheckResourceAttr("aptible_replica.test", "enable_backups", "false"),
// TEMPORARILY DISABLED - PITR must be disabled before backups can be disabled
// resource.TestCheckResourceAttr("aptible_replica.test", "enable_backups", "false"),
resource.TestCheckResourceAttrSet("aptible_replica.test", "replica_id"),
resource.TestCheckResourceAttrSet("aptible_replica.test", "default_connection_url"),
),
Expand Down Expand Up @@ -134,16 +135,17 @@ func TestAccResourceReplica_update(t *testing.T) {
ImportState: true,
ImportStateVerify: true,
},
{
Config: testAccAptibleReplicaUpdate(env.ID, dbHandle, replicaHandle),
Check: resource.ComposeTestCheckFunc(
resource.TestCheckResourceAttr("aptible_replica.test", "container_profile", "r5"),
resource.TestCheckResourceAttr("aptible_replica.test", "iops", "4000"),
resource.TestCheckResourceAttr("aptible_replica.test", "container_size", "512"),
resource.TestCheckResourceAttr("aptible_replica.test", "disk_size", "20"),
resource.TestCheckResourceAttr("aptible_replica.test", "enable_backups", "false"),
),
},
// TEMPORARILY DISABLED - Step 3: PITR must be disabled before backups can be disabled
// {
// Config: testAccAptibleReplicaUpdate(env.ID, dbHandle, replicaHandle),
// Check: resource.ComposeTestCheckFunc(
// resource.TestCheckResourceAttr("aptible_replica.test", "container_profile", "r5"),
// resource.TestCheckResourceAttr("aptible_replica.test", "iops", "4000"),
// resource.TestCheckResourceAttr("aptible_replica.test", "container_size", "512"),
// resource.TestCheckResourceAttr("aptible_replica.test", "disk_size", "20"),
// resource.TestCheckResourceAttr("aptible_replica.test", "enable_backups", "false"),
// ),
// },
},
})
})
Expand Down Expand Up @@ -286,6 +288,7 @@ func testAccAptibleReplicaWithoutBackups(envId int64, dbHandle string, replicaHa
`, envId, dbHandle, envId, replicaHandle)
}

//nolint:unused // Will be re-enabled once PITR bug is fixed
func testAccAptibleReplicaUpdate(envId int64, dbHandle string, repHandle string) string {
return fmt.Sprintf(`
resource "aptible_database" "test" {
Expand Down