Skip to content

Conversation

@vkaylee
Copy link

@vkaylee vkaylee commented Jul 5, 2022

It may relate to Fixes #783

Requirements

All new code should be covered with tests, documentation should be updated. CI should pass.

Description of the Change

Guide here
Add linkMehod: absoluteSymlink, relativeSymlink

The default one is symlink. It will be treated as absoluteSymlink

Add to the document. Pull request here aptly-dev/www.aptly.info#98

Checklist

  • unit-test added (if change is algorithm)
  • functional test added/updated (if change is functional)
  • man page updated (if applicable)
  • bash completion updated (if applicable)
  • documentation updated
  • author name in AUTHORS

@codecov
Copy link

codecov bot commented Jul 11, 2022

Codecov Report

❌ Patch coverage is 77.27273% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.31%. Comparing base (f0a85b2) to head (2d37175).
⚠️ Report is 559 commits behind head on master.

Files with missing lines Patch % Lines
files/package_pool.go 76.92% 2 Missing and 1 partial ⚠️
files/public.go 77.77% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1092      +/-   ##
==========================================
- Coverage   66.31%   66.31%   -0.01%     
==========================================
  Files         141      141              
  Lines       15890    15906      +16     
==========================================
+ Hits        10538    10548      +10     
- Misses       4603     4606       +3     
- Partials      749      752       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@randombenj
Copy link
Contributor

@vleedev failing tests should be fixed now, would you mind rebasing?

@vkaylee
Copy link
Author

vkaylee commented Jul 13, 2022

@vleedev failing tests should be fixed now, would you mind rebasing?

It has been rebased. Could you trigger CI?

@randombenj
Copy link
Contributor

Generally the changes look good, so thanks for your contribution!
Two things however:

  • absoluteSymlink does not seem to work, it will create a hardlink, only symlink works, could you have a look at that
  • The rebasing seems to have gone wild, there are some commits from master also in this branch now, could you maybe fix this as well?

@randombenj
Copy link
Contributor

Close due to inactivity ...

@randombenj randombenj closed this May 1, 2023
@neolynx neolynx removed the request for review from randombenj April 24, 2024 19:54
@neolynx neolynx self-assigned this Apr 24, 2024
@neolynx neolynx reopened this Feb 22, 2025
@neolynx neolynx added needs rebase The PR needs to be rebased on master help wanted ! Please help getting this PR merged :-) and removed wishlist labels Jan 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

help wanted ! Please help getting this PR merged :-) needs rebase The PR needs to be rebased on master

Projects

None yet

Development

Successfully merging this pull request may close these issues.

when publishing, use relative symbolic links

3 participants