[lint] Added empty_if lint and tests

[Helios-vmg]

Description

This PR adds a new lint to aptos move lint: check for ifs without body, for example:

if (x) {
}

How Has This Been Tested?

Added test in move_linter/tests folder.

This lint do not triggers in any file in aptos-move/framework/*.

Key Areas to Review

• Recognized patterns are enough?
• Message is clear?

Type of Change

• New feature

Which Components or Systems Does This Change Impact?

• Other (move_linter)

Checklist

• I have read and followed the CONTRIBUTING doc
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I identified and added all stakeholders and component owners affected by this change as reviewers
• I tested both happy and unhappy path of the functionality
• I have made corresponding changes to the documentation

[junxzm1990]

@rahxephon89 it seems all comments are addressed. can you approve it?

[github-actions]

✅ Forge suite compat success on 75cc050c2c35782fc994c2a7e61a7fb3ea88f71f ==> 09de6116207d334275e486b294546e47165b02d9

Compatibility test results for 75cc050c2c35782fc994c2a7e61a7fb3ea88f71f ==> 09de6116207d334275e486b294546e47165b02d9 (PR)
1. Check liveness of validators at old version: 75cc050c2c35782fc994c2a7e61a7fb3ea88f71f
compatibility::simple-validator-upgrade::liveness-check : committed: 14402.74 txn/s, latency: 2397.86 ms, (p50: 2500 ms, p70: 2600, p90: 2800 ms, p99: 3600 ms), latency samples: 470000
2. Upgrading first Validator to new version: 09de6116207d334275e486b294546e47165b02d9
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 5294.31 txn/s, latency: 6473.84 ms, (p50: 7200 ms, p70: 7200, p90: 7300 ms, p99: 7400 ms), latency samples: 183220
3. Upgrading rest of first batch to new version: 09de6116207d334275e486b294546e47165b02d9
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 5385.67 txn/s, latency: 6406.36 ms, (p50: 7200 ms, p70: 7200, p90: 7300 ms, p99: 7400 ms), latency samples: 185060
4. upgrading second batch to new version: 09de6116207d334275e486b294546e47165b02d9
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 8385.29 txn/s, latency: 4088.23 ms, (p50: 4400 ms, p70: 4500, p90: 4600 ms, p99: 4800 ms), latency samples: 278140
5. check swarm health
Compatibility test for 75cc050c2c35782fc994c2a7e61a7fb3ea88f71f ==> 09de6116207d334275e486b294546e47165b02d9 passed
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking

[github-actions]

✅ Forge suite realistic_env_max_load success on 09de6116207d334275e486b294546e47165b02d9

two traffics test: inner traffic : committed: 13529.01 txn/s, submitted: 13529.17 txn/s, expired: 0.16 txn/s, latency: 2791.48 ms, (p50: 2700 ms, p70: 2700, p90: 3200 ms, p99: 5100 ms), latency samples: 5144120
two traffics test : committed: 99.96 txn/s, latency: 789.94 ms, (p50: 800 ms, p70: 800, p90: 900 ms, p99: 1200 ms), latency samples: 1720
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 2.317, avg: 2.107", "ConsensusProposalToOrdered: max: 0.167, avg: 0.164", "ConsensusOrderedToCommit: max: 0.180, avg: 0.106", "ConsensusProposalToCommit: max: 0.345, avg: 0.270"]
Max non-epoch-change gap was: 2 rounds at version 5627936 (avg 0.00) [limit 4], 2.20s no progress at version 5627936 (avg 0.07s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.22s no progress at version 2397642 (avg 0.22s) [limit 16].
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking

[github-actions]

✅ Forge suite framework_upgrade success on 75cc050c2c35782fc994c2a7e61a7fb3ea88f71f ==> 09de6116207d334275e486b294546e47165b02d9

Compatibility test results for 75cc050c2c35782fc994c2a7e61a7fb3ea88f71f ==> 09de6116207d334275e486b294546e47165b02d9 (PR)
Upgrade the nodes to version: 09de6116207d334275e486b294546e47165b02d9
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 2032.78 txn/s, submitted: 2041.37 txn/s, failed submission: 8.59 txn/s, expired: 8.59 txn/s, latency: 1414.88 ms, (p50: 1400 ms, p70: 1500, p90: 2000 ms, p99: 2700 ms), latency samples: 184680
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 2096.48 txn/s, submitted: 2102.65 txn/s, failed submission: 6.17 txn/s, expired: 6.17 txn/s, latency: 1420.83 ms, (p50: 1500 ms, p70: 1500, p90: 1800 ms, p99: 2400 ms), latency samples: 190361
5. check swarm health
Compatibility test for 75cc050c2c35782fc994c2a7e61a7fb3ea88f71f ==> 09de6116207d334275e486b294546e47165b02d9 passed
Upgrade the remaining nodes to version: 09de6116207d334275e486b294546e47165b02d9
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 2187.73 txn/s, submitted: 2194.39 txn/s, failed submission: 6.66 txn/s, expired: 6.66 txn/s, latency: 1363.14 ms, (p50: 1200 ms, p70: 1500, p90: 1800 ms, p99: 3000 ms), latency samples: 197081
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking