Fix comments for AccumulatorRangeProof

[wqfish]

The comments are wrong and confused me quite a bit.

The siblings are generated by
AncestorSiblingIterator
which produces siblings from bottom to the root.

[github-actions]

✅ Forge suite compat success on 84085c5d65a282d6bcd49e1113e3b7e7d83c0740 ==> 2ea4f44b4e41aa80d5ddaa2d074b9850d0592f20

Compatibility test results for 84085c5d65a282d6bcd49e1113e3b7e7d83c0740 ==> 2ea4f44b4e41aa80d5ddaa2d074b9850d0592f20 (PR)
1. Check liveness of validators at old version: 84085c5d65a282d6bcd49e1113e3b7e7d83c0740
compatibility::simple-validator-upgrade::liveness-check : committed: 14365.16 txn/s, latency: 2403.11 ms, (p50: 2500 ms, p70: 2600, p90: 2800 ms, p99: 3600 ms), latency samples: 470640
2. Upgrading first Validator to new version: 2ea4f44b4e41aa80d5ddaa2d074b9850d0592f20
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 5234.08 txn/s, latency: 6591.00 ms, (p50: 7300 ms, p70: 7400, p90: 7500 ms, p99: 7500 ms), latency samples: 181320
3. Upgrading rest of first batch to new version: 2ea4f44b4e41aa80d5ddaa2d074b9850d0592f20
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 5258.82 txn/s, latency: 6511.45 ms, (p50: 7200 ms, p70: 7300, p90: 7300 ms, p99: 7400 ms), latency samples: 182120
4. upgrading second batch to new version: 2ea4f44b4e41aa80d5ddaa2d074b9850d0592f20
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 8129.48 txn/s, latency: 4174.87 ms, (p50: 4500 ms, p70: 4600, p90: 4700 ms, p99: 4800 ms), latency samples: 272460
5. check swarm health
Compatibility test for 84085c5d65a282d6bcd49e1113e3b7e7d83c0740 ==> 2ea4f44b4e41aa80d5ddaa2d074b9850d0592f20 passed
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking

[github-actions]

✅ Forge suite realistic_env_max_load success on 2ea4f44b4e41aa80d5ddaa2d074b9850d0592f20

two traffics test: inner traffic : committed: 13782.53 txn/s, latency: 2733.68 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 3300 ms), latency samples: 5240440
two traffics test : committed: 99.99 txn/s, latency: 769.51 ms, (p50: 700 ms, p70: 800, p90: 900 ms, p99: 1200 ms), latency samples: 1740
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 2.193, avg: 2.116", "ConsensusProposalToOrdered: max: 0.166, avg: 0.164", "ConsensusOrderedToCommit: max: 0.086, avg: 0.078", "ConsensusProposalToCommit: max: 0.250, avg: 0.242"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.70s no progress at version 5247255 (avg 0.07s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.26s no progress at version 2379113 (avg 0.26s) [limit 16].
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking

[github-actions]

✅ Forge suite framework_upgrade success on 84085c5d65a282d6bcd49e1113e3b7e7d83c0740 ==> 2ea4f44b4e41aa80d5ddaa2d074b9850d0592f20

Forge report malformed: Expecting property name enclosed in double quotes: line 4 column 1 (char 23)
'{\n  "metrics": [\n    {\n[2025-10-17T23:37:11Z INFO  aptos_forge::report] Test Ok\n      "test_name": "framework_upgrade::framework-upgrade::full-framework-upgrade",\n      "metric": "submitted_txn",\n      "value": 178002.0\n    },\n    {\n      "test_name": "framework_upgrade::framework-upgrade::full-framework-upgrade",\n      "metric": "expired_txn",\n      "value": 620.0\n    },\n    {\n      "test_name": "framework_upgrade::framework-upgrade::full-framework-upgrade",\n      "metric": "avg_tps",\n      "value": 1945.3631791764578\n    },\n    {\n      "test_name": "framework_upgrade::framework-upgrade::full-framework-upgrade",\n      "metric": "avg_latency",\n      "value": 1487.5446775884814\n    },\n    {\n      "test_name": "framework_upgrade::framework-upgrade::full-framework-upgrade",\n      "metric": "p50_latency",\n      "value": 1500.0\n    },\n    {\n      "test_name": "framework_upgrade::framework-upgrade::full-framework-upgrade",\n      "metric": "p90_latency",\n      "value": 1900.0\n    },\n    {\n      "test_name": "framework_upgrade::framework-upgrade::full-framework-upgrade",\n      "metric": "p99_latency",\n      "value": 2700.0\n    },\n    {\n      "test_name": "framework_upgrade::framework-upgrade::full-framework-upgrade",\n      "metric": "submitted_txn",\n      "value": 177743.0\n    },\n    {\n      "test_name": "framework_upgrade::framework-upgrade::full-framework-upgrade",\n      "metric": "expired_txn",\n      "value": 640.0\n    },\n    {\n      "test_name": "framework_upgrade::framework-upgrade::full-framework-upgrade",\n      "metric": "avg_tps",\n      "value": 1935.050901623939\n    },\n    {\n      "test_name": "framework_upgrade::framework-upgrade::full-framework-upgrade",\n      "metric": "avg_latency",\n      "value": 1493.9533604738485\n    },\n    {\n      "test_name": "framework_upgrade::framework-upgrade::full-framework-upgrade",\n      "metric": "p50_latency",\n      "value": 1500.0\n    },\n    {\n      "test_name": "framework_upgrade::framework-upgrade::full-framework-upgrade",\n      "metric": "p90_latency",\n      "value": 2100.0\n    },\n    {\n      "test_name": "framework_upgrade::framework-upgrade::full-framework-upgrade",\n      "metric": "p99_latency",\n      "value": 2900.0\n    },\n    {\n      "test_name": "framework_upgrade::framework-upgrade::full-framework-upgrade",\n      "metric": "submitted_txn",\n      "value": 209741.0\n    },\n    {\n      "test_name": "framework_upgrade::framework-upgrade::full-framework-upgrade",\n      "metric": "expired_txn",\n      "value": 680.0\n    },\n    {\n      "test_name": "framework_upgrade::framework-upgrade::full-framework-upgrade",\n      "metric": "avg_tps",\n      "value": 2293.6705457131193\n    },\n    {\n      "test_name": "framework_upgrade::framework-upgrade::full-framework-upgrade",\n      "metric": "avg_latency",\n      "value": 1263.6708663978457\n    },\n    {\n      "test_name": "framework_upgrade::framework-upgrade::full-framework-upgrade",\n      "metric": "p50_latency",\n      "value": 1200.0\n    },\n    {\n      "test_name": "framework_upgrade::framework-upgrade::full-framework-upgrade",\n      "metric": "p90_latency",\n      "value": 1500.0\n    },\n    {\n      "test_name": "framework_upgrade::framework-upgrade::full-framework-upgrade",\n      "metric": "p99_latency",\n      "value": 2000.0\n    }\n  ],\n  "text": "Compatibility test results for 84085c5d65a282d6bcd49e1113e3b7e7d83c0740 ==> 2ea4f44b4e41aa80d5ddaa2d074b9850d0592f20 (PR)\\nUpgrade the nodes to version: 2ea4f44b4e41aa80d5ddaa2d074b9850d0592f20\\nframework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1945.36 txn/s, submitted: 1952.16 txn/s, failed submission: 6.80 txn/s, expired: 6.80 txn/s, latency: 1487.54 ms, (p50: 1500 ms, p70: 1500, p90: 1900 ms, p99: 2700 ms), latency samples: 177382\\nframework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1935.05 txn/s, submitted: 1942.04 txn/s, failed submission: 6.99 txn/s, expired: 6.99 txn/s, latency: 1493.95 ms, (p50: 1500 ms, p70: 1600, p90: 2100 ms, p99: 2900 ms), latency samples: 177103\\n5. check swarm health\\nCompatibility test for 84085c5d65a282d6bcd49e1113e3b7e7d83c0740 ==> 2ea4f44b4e41aa80d5ddaa2d074b9850d0592f20 passed\\nUpgrade the remaining nodes to version: 2ea4f44b4e41aa80d5ddaa2d074b9850d0592f20\\nframework_upgrade::framework-upgrade::full-framework-upgrade : committed: 2293.67 txn/s, submitted: 2301.13 txn/s, failed submission: 7.46 txn/s, expired: 7.46 txn/s, latency: 1263.67 ms, (p50: 1200 ms, p70: 1500, p90: 1500 ms, p99: 2000 ms), latency samples: 209061\\nTest Ok"\n}'
Trailing Log Lines:
Compatibility test results for 84085c5d65a282d6bcd49e1113e3b7e7d83c0740 ==> 2ea4f44b4e41aa80d5ddaa2d074b9850d0592f20 (PR)
Upgrade the nodes to version: 2ea4f44b4e41aa80d5ddaa2d074b9850d0592f20
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1945.36 txn/s, submitted: 1952.16 txn/s, failed submission: 6.80 txn/s, expired: 6.80 txn/s, latency: 1487.54 ms, (p50: 1500 ms, p70: 1500, p90: 1900 ms, p99: 2700 ms), latency samples: 177382
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1935.05 txn/s, submitted: 1942.04 txn/s, failed submission: 6.99 txn/s, expired: 6.99 txn/s, latency: 1493.95 ms, (p50: 1500 ms, p70: 1600, p90: 2100 ms, p99: 2900 ms), latency samples: 177103
5. check swarm health
Compatibility test for 84085c5d65a282d6bcd49e1113e3b7e7d83c0740 ==> 2ea4f44b4e41aa80d5ddaa2d074b9850d0592f20 passed
Upgrade the remaining nodes to version: 2ea4f44b4e41aa80d5ddaa2d074b9850d0592f20
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 2293.67 txn/s, submitted: 2301.13 txn/s, failed submission: 7.46 txn/s, expired: 7.46 txn/s, latency: 1263.67 ms, (p50: 1200 ms, p70: 1500, p90: 1500 ms, p99: 2000 ms), latency samples: 209061
Test Ok

=== BEGIN JUNIT ===
<?xml version="1.0" encoding="UTF-8"?>
<testsuites name="forge" tests="1" failures="0" errors="0" uuid="af1a28fe-e2c0-4b39-8e9f-9e75d9d3a62f">
    <testsuite name="local" tests="1" disabled="0" errors="0" failures="0">
        <testcase name="framework_upgrade::framework-upgrade">
        </testcase>
    </testsuite>
</testsuites>
=== END JUNIT ===
[2025-10-17T23:37:11Z INFO  aptos_forge::backend::k8s::cluster_helper] Deleting namespace forge-framework-upgrade-pr-17800: Some(NamespaceStatus { conditions: None, phase: Some("Terminating") })
[2025-10-17T23:37:11Z INFO  aptos_forge::backend::k8s::cluster_helper] aptos-node resources for Forge removed in namespace: forge-framework-upgrade-pr-17800

test result: ok. 1 passed; 0 soft failed; 0 hard failed; 0 filtered out

Debugging output:
NAME                                         READY   STATUS      RESTARTS   AGE
aptos-node-0-validator-0                     1/1     Running     0          11m
aptos-node-1-validator-0                     1/1     Running     0          10m
aptos-node-2-validator-0                     1/1     Running     0          3m6s
aptos-node-3-validator-0                     1/1     Running     0          2m34s
forge-testnet-deployer-878dk                 0/1     Completed   0          14m
genesis-aptos-genesis-eforgeb7dbc887-6gdsd   0/1     Completed   0          13m

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking