Skip to content

[move] delete unused code #17849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 15, 2025
Merged

[move] delete unused code #17849

merged 2 commits into from
Oct 15, 2025
+30 −1,748

Conversation

rahxephon89
Copy link
Contributor

@rahxephon89 rahxephon89 commented Oct 11, 2025 •
edited
Loading

Description

This PR removes code related to normalized type, signature checker v1 and legacy compatibility checker.

close #17595

How Has This Been Tested?

Existing tests still pass

Key Areas to Review

whether code in bytecode verifier crate is properly removed.

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

@rahxephon89 rahxephon89 force-pushed the teng/remove-legacy-compatibility branch from 288cf65 to db4230c Compare October 11, 2025 03:13
@rahxephon89 rahxephon89 changed the title [WIP][test] delete unused code [move] delete unused code Oct 11, 2025
@rahxephon89 rahxephon89 force-pushed the teng/remove-legacy-compatibility branch from db4230c to 73edcb5 Compare October 11, 2025 03:22
@rahxephon89 rahxephon89 marked this pull request as ready for review October 11, 2025 03:37
@rahxephon89 rahxephon89 added the CICD:build-images when this label is present github actions will start build+push rust images from the PR. label Oct 11, 2025
georgemitenkov
georgemitenkov approved these changes Oct 11, 2025
View reviewed changes
Copy link
Contributor

@georgemitenkov georgemitenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replay passes right?

@rahxephon89 rahxephon89 force-pushed the teng/remove-legacy-compatibility branch from 73edcb5 to 9d32df8 Compare October 11, 2025 21:05
@rahxephon89
Copy link
Contributor Author

Replay passes right?

yes, it passes on both mainnet and testnet

@rahxephon89 rahxephon89 mentioned this pull request Oct 14, 2025
Merged
16 tasks
@rahxephon89 rahxephon89 force-pushed the teng/remove-legacy-compatibility branch from 9d32df8 to f39fd7d Compare October 15, 2025 02:58
@rahxephon89 rahxephon89 enabled auto-merge (squash) October 15, 2025 12:06
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link
Contributor

✅ Forge suite compat success on cef91202017aab6af466f948737fcd7d97dc7d13 ==> fbb3c8a42e1a4515803186c51622d8311c828744

Compatibility test results for cef91202017aab6af466f948737fcd7d97dc7d13 ==> fbb3c8a42e1a4515803186c51622d8311c828744 (PR)
1. Check liveness of validators at old version: cef91202017aab6af466f948737fcd7d97dc7d13
compatibility::simple-validator-upgrade::liveness-check : committed: 14245.61 txn/s, latency: 2428.54 ms, (p50: 2500 ms, p70: 2700, p90: 2800 ms, p99: 3700 ms), latency samples: 464180
2. Upgrading first Validator to new version: fbb3c8a42e1a4515803186c51622d8311c828744
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 5229.94 txn/s, latency: 6587.50 ms, (p50: 7400 ms, p70: 7400, p90: 7500 ms, p99: 7500 ms), latency samples: 180720
3. Upgrading rest of first batch to new version: fbb3c8a42e1a4515803186c51622d8311c828744
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 5250.05 txn/s, latency: 6560.34 ms, (p50: 7300 ms, p70: 7300, p90: 7400 ms, p99: 7500 ms), latency samples: 181520
4. upgrading second batch to new version: fbb3c8a42e1a4515803186c51622d8311c828744
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 8228.51 txn/s, latency: 4130.26 ms, (p50: 4500 ms, p70: 4600, p90: 4700 ms, p99: 4800 ms), latency samples: 274260
5. check swarm health
Compatibility test for cef91202017aab6af466f948737fcd7d97dc7d13 ==> fbb3c8a42e1a4515803186c51622d8311c828744 passed
Test Ok

@github-actions GitHub Actions
Copy link
Contributor

✅ Forge suite realistic_env_max_load success on fbb3c8a42e1a4515803186c51622d8311c828744

two traffics test: inner traffic : committed: 13902.88 txn/s, latency: 2706.12 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 4800 ms), latency samples: 5286180
two traffics test : committed: 99.96 txn/s, latency: 1061.89 ms, (p50: 800 ms, p70: 1200, p90: 1700 ms, p99: 2200 ms), latency samples: 1720
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 2.179, avg: 1.886", "ConsensusProposalToOrdered: max: 0.169, avg: 0.164", "ConsensusOrderedToCommit: max: 0.536, avg: 0.237", "ConsensusProposalToCommit: max: 0.703, avg: 0.401"]
Max non-epoch-change gap was: 2 rounds at version 3714205 (avg 0.00) [limit 4], 2.25s no progress at version 3714205 (avg 0.07s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.79s no progress at version 2427203 (avg 0.79s) [limit 16].
Test Ok

@github-actions GitHub Actions
Copy link
Contributor

✅ Forge suite framework_upgrade success on cef91202017aab6af466f948737fcd7d97dc7d13 ==> fbb3c8a42e1a4515803186c51622d8311c828744

Compatibility test results for cef91202017aab6af466f948737fcd7d97dc7d13 ==> fbb3c8a42e1a4515803186c51622d8311c828744 (PR)
Upgrade the nodes to version: fbb3c8a42e1a4515803186c51622d8311c828744
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 2092.91 txn/s, submitted: 2102.02 txn/s, failed submission: 9.12 txn/s, expired: 9.12 txn/s, latency: 1402.82 ms, (p50: 1500 ms, p70: 1500, p90: 1800 ms, p99: 2000 ms), latency samples: 188281
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1374.56 txn/s, submitted: 1377.45 txn/s, failed submission: 2.89 txn/s, expired: 2.89 txn/s, latency: 2199.34 ms, (p50: 1500 ms, p70: 1500, p90: 2400 ms, p99: 11500 ms), latency samples: 123861
5. check swarm health
Compatibility test for cef91202017aab6af466f948737fcd7d97dc7d13 ==> fbb3c8a42e1a4515803186c51622d8311c828744 passed
Upgrade the remaining nodes to version: fbb3c8a42e1a4515803186c51622d8311c828744
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 2036.42 txn/s, submitted: 2043.38 txn/s, failed submission: 6.95 txn/s, expired: 6.95 txn/s, latency: 1878.60 ms, (p50: 1400 ms, p70: 1500, p90: 1800 ms, p99: 12100 ms), latency samples: 181540
Test Ok

@rahxephon89 rahxephon89 merged commit 535c6b5 into main Oct 15, 2025
88 of 89 checks passed
@rahxephon89 rahxephon89 deleted the teng/remove-legacy-compatibility branch October 15, 2025 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wrwg wrwg wrwg approved these changes

@georgemitenkov georgemitenkov georgemitenkov approved these changes

@junxzm1990 junxzm1990 Awaiting requested review from junxzm1990

@vgao1996 vgao1996 Awaiting requested review from vgao1996

@JakeSilverman JakeSilverman Awaiting requested review from JakeSilverman

Assignees

No one assigned

Labels

CICD:build-images when this label is present github actions will start build+push rust images from the PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[move-binary-format][refactor] Remove compatibility_legacy.rs

3 participants

@rahxephon89 @wrwg @georgemitenkov