[telemetry] support prometheus sink #18336
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustielin
force-pushed
the
12-17-_telemetry_support_prometheus_sink
branch
3 times, most recently
from
c408abc to
d795e3c
Compare
rustielin
force-pushed
the
12-17-_telemetry_support_prometheus_sink
branch
2 times, most recently
from
82accfa to
df61586
Compare
rustielin
force-pushed
the
12-17-_telemetry_support_prometheus_sink
branch
from
df61586 to
a8c9dc0
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| ) | ||
| } | ||
| }, | ||
| SinkAuthType::None => victoria_metrics::AuthToken::Bearer("".to_string()), |
There was a problem hiding this comment.
Metrics clients send empty Bearer auth when auth_type is none
Medium Severity
When auth_type: none is configured, metrics clients (VictoriaMetricsClient, PrometheusRemoteWriteClient) still send an Authorization: Bearer header with an empty token. This happens because SinkAuthType::None maps to AuthToken::Bearer("") instead of truly disabling authentication. The Loki client correctly handles this with a LokiAuth::None variant that skips adding any auth header, but the metrics AuthToken enum lacks a None variant. This inconsistency could cause issues with strict servers that reject malformed auth headers.
Additional Locations (2)
crates/aptos-telemetry-service/src/clients/prometheus_remote_write.rs
Outdated
Show resolved
Hide resolved
rustielin
force-pushed
the
12-17-_telemetry_support_prometheus_sink
branch
from
a8c9dc0 to
e032be9
Compare
JoshLind
approved these changes
Jan 9, 2026
Contributor
JoshLind
left a comment
JoshLind
left a comment
There was a problem hiding this comment.
Unblocking!
(Big boss @ibalajiarun can give the final stamp 😄 Most of this is dark magic to me.)
| serde = { workspace = true } | ||
| serde_json = { workspace = true } | ||
| serde_yaml = { workspace = true } | ||
| snap = "1.1" |
Contributor
There was a problem hiding this comment.
You don't want to use the workspace version?
Contributor
Author
There was a problem hiding this comment.
It's only used in this crate actually, so doesn't make sense to include it in the workspace
ibalajiarun
approved these changes
Jan 12, 2026
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
✅ Forge suite
|
Contributor
✅ Forge suite
|
Contributor
✅ Forge suite
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support prometheus and prometheus compatible metrics sinks via remote write. Previously only VictoriaMetrics prometheus import endpoint was supported
How Has This Been Tested?
Key Areas to Review
New prometheus remote write sink
Type of Change
Which Components or Systems Does This Change Impact?
Checklist
Note
Introduces a Prometheus Remote Write metrics sink and refactors ingestion to support multiple backends with flexible auth.
prometheus_remote_writeclient (protobuf + snappy) and unifiedMetricsIngestClient; refactors VictoriaMetrics clientbackend_type(victoria_metrics|prometheus_remote_write / humio|loki),auth_type(bearer|basic|none),keys_env_var/basic_auth_env_var, and support bothmetrics_sinkandmetrics_sinks/api/v1/healthendpoint; update tests to use new clients; minor renames/struct movesprostandsnapWritten by Cursor Bugbot for commit a8c9dc0. This will update automatically on new commits. Configure here.