-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Enable memory profiling by default #18341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c37f0fe to
0b5a8b1
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
zekun000
approved these changes
Jan 7, 2026
grao1991
approved these changes
Jan 7, 2026
`lg_prof_sample` is set to 23 and hopefully performance impact is minimal. Benchmark is not showing anything. If this causes any issues, it can still be overwritten by setting `MALLOC_CONF` env var on the command line.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
✅ Forge suite
|
Contributor
✅ Forge suite
|
Contributor
✅ Forge suite
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CICD:run-e2e-tests
when this label is present github actions will run all land-blocking e2e tests from the PR
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lg_prof_sampleis set to 23 and hopefully performance impact is minimal. Benchmark is not showinganything. If this causes any issues, it can still be overwritten by setting
MALLOC_CONFenv var onthe command line.
Note
Enables memory profiling by default with jemalloc and updates allocator deps.
malloc_conf(prof:true,lg_prof_sample:23) inaptos-nodeandexecution/executor-benchmarkon Unix; can be overridden viaMALLOC_CONFaptos-nodecrate attribute from#![forbid(unsafe_code)]to#![deny(unsafe_code)]to allow the unsafemalloc_confsymboltikv-jemallocator,tikv-jemalloc-ctl, andtikv-jemalloc-systo0.6.1inCargo.tomlandCargo.lockWritten by Cursor Bugbot for commit ff7d429. This will update automatically on new commits. Configure here.