[cp][aptos-release-v1.39] [Network] Small cleanups to streaming code.

[aptos-bot]

Backport

This will backport the following commits from main to aptos-release-v1.39:

• [Network] Small cleaups to streaming code. (#18375)

Questions ?

Please refer to the Backport tool documentation

---

Note

Improves robustness of streaming by enforcing stricter bounds and accounting for framing overhead.

• Adds FRAME_OVERHEAD_BYTES and adjusts OutboundStream::new() to safely subtract overhead; asserts message-size support and u8 chunk limits
• Forbids streaming NetworkMessage::Error(_); validates message/frame sizes in stream_message() and guards chunk count/IDs
• Tightens InboundStream validation: non-zero and bounded max_fragments, non-zero/in-order fragment_id, request ID matching; renames internal counter to received_fragment_id
• Clarifies errors and messages in InboundStreamBuffer; returns completed NetworkMessage when stream ends
• Adds unit tests covering stream creation, fragment appends (order, bounds), and max-fragment cases

^{Written by Cursor Bugbot for commit 1eaa7d3. This will update automatically on new commits. Configure here.}

[github-actions]

✅ Forge suite compat success on 4e5060ed0360038498c14cde6d00f18fe6746672 ==> 1eaa7d33423dc28d54367a8457e855eb5e45b421

Compatibility test results for 4e5060ed0360038498c14cde6d00f18fe6746672 ==> 1eaa7d33423dc28d54367a8457e855eb5e45b421 (PR)
1. Check liveness of validators at old version: 4e5060ed0360038498c14cde6d00f18fe6746672
compatibility::simple-validator-upgrade::liveness-check : committed: 12185.62 txn/s, latency: 2833.67 ms, (p50: 3000 ms, p70: 3100, p90: 3500 ms, p99: 3900 ms), latency samples: 404660
2. Upgrading first Validator to new version: 1eaa7d33423dc28d54367a8457e855eb5e45b421
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 6125.38 txn/s, latency: 5462.22 ms, (p50: 6000 ms, p70: 6100, p90: 6200 ms, p99: 6300 ms), latency samples: 213120
3. Upgrading rest of first batch to new version: 1eaa7d33423dc28d54367a8457e855eb5e45b421
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 5950.63 txn/s, latency: 5650.30 ms, (p50: 6200 ms, p70: 6400, p90: 6600 ms, p99: 6800 ms), latency samples: 204120
4. upgrading second batch to new version: 1eaa7d33423dc28d54367a8457e855eb5e45b421
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 9467.40 txn/s, latency: 3476.62 ms, (p50: 3600 ms, p70: 4000, p90: 4500 ms, p99: 5800 ms), latency samples: 320080
5. check swarm health
Compatibility test for 4e5060ed0360038498c14cde6d00f18fe6746672 ==> 1eaa7d33423dc28d54367a8457e855eb5e45b421 passed
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking

[github-actions]

✅ Forge suite realistic_env_max_load success on 1eaa7d33423dc28d54367a8457e855eb5e45b421

two traffics test: inner traffic : committed: 13540.86 txn/s, latency: 2781.57 ms, (p50: 2700 ms, p70: 3000, p90: 3200 ms, p99: 3600 ms), latency samples: 5042840
two traffics test : committed: 100.01 txn/s, latency: 720.62 ms, (p50: 700 ms, p70: 700, p90: 800 ms, p99: 1000 ms), latency samples: 1680
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 2.289, avg: 2.208", "ConsensusProposalToOrdered: max: 0.169, avg: 0.166", "ConsensusOrderedToCommit: max: 0.055, avg: 0.049", "ConsensusProposalToCommit: max: 0.220, avg: 0.215"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.42s no progress at version 537 (avg 0.07s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.25s no progress at version 2401757 (avg 0.25s) [limit 16].
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking

[github-actions]

✅ Forge suite framework_upgrade success on 4e5060ed0360038498c14cde6d00f18fe6746672 ==> 1eaa7d33423dc28d54367a8457e855eb5e45b421

Forge report malformed: Expecting property name enclosed in double quotes: line 16 column 1 (char 434)
'{\n  "metrics": [\n    {\n      "test_name": "framework_upgrade::framework-upgrade::full-framework-upgrade",\n      "metric": "submitted_txn",\n      "value": 189543.0\n    },\n    {\n      "test_name": "framework_upgrade::framework-upgrade::full-framework-upgrade",\n      "metric": "expired_txn",\n      "value": 480.0\n    },\n    {\n      "test_name": "framework_upgrade::framework-upgrade::full-framework-upgrade",\n      "metric": "avg_tps",\n[2026-01-08T21:43:05Z INFO  aptos_forge::report] Test Ok\n      "value": 2076.812105347304\n    },\n    {\n      "test_name": "framework_upgrade::framework-upgrade::full-framework-upgrade",\n      "metric": "avg_latency",\n      "value": 1418.7789467003063\n    },\n    {\n      "test_name": "framework_upgrade::framework-upgrade::full-framework-upgrade",\n      "metric": "p50_latency",\n      "value": 1400.0\n    },\n    {\n      "test_name": "framework_upgrade::framework-upgrade::full-framework-upgrade",\n      "metric": "p90_latency",\n      "value": 1800.0\n    },\n    {\n      "test_name": "framework_upgrade::framework-upgrade::full-framework-upgrade",\n      "metric": "p99_latency",\n      "value": 2400.0\n    },\n    {\n      "test_name": "framework_upgrade::framework-upgrade::full-framework-upgrade",\n      "metric": "submitted_txn",\n      "value": 212640.0\n    },\n    {\n      "test_name": "framework_upgrade::framework-upgrade::full-framework-upgrade",\n      "metric": "expired_txn",\n      "value": 660.0\n    },\n    {\n      "test_name": "framework_upgrade::framework-upgrade::full-framework-upgrade",\n      "metric": "avg_tps",\n      "value": 2332.7954174443744\n    },\n    {\n      "test_name": "framework_upgrade::framework-upgrade::full-framework-upgrade",\n      "metric": "avg_latency",\n      "value": 1262.351094442872\n    },\n    {\n      "test_name": "framework_upgrade::framework-upgrade::full-framework-upgrade",\n      "metric": "p50_latency",\n      "value": 1200.0\n    },\n    {\n      "test_name": "framework_upgrade::framework-upgrade::full-framework-upgrade",\n      "metric": "p90_latency",\n      "value": 1500.0\n    },\n    {\n      "test_name": "framework_upgrade::framework-upgrade::full-framework-upgrade",\n      "metric": "p99_latency",\n      "value": 1800.0\n    },\n    {\n      "test_name": "framework_upgrade::framework-upgrade::full-framework-upgrade",\n      "metric": "submitted_txn",\n      "value": 210821.0\n    },\n    {\n      "test_name": "framework_upgrade::framework-upgrade::full-framework-upgrade",\n      "metric": "expired_txn",\n      "value": 660.0\n    },\n    {\n      "test_name": "framework_upgrade::framework-upgrade::full-framework-upgrade",\n      "metric": "avg_tps",\n      "value": 2310.2079143924384\n    },\n    {\n      "test_name": "framework_upgrade::framework-upgrade::full-framework-upgrade",\n      "metric": "avg_latency",\n      "value": 1266.9176440919105\n    },\n    {\n      "test_name": "framework_upgrade::framework-upgrade::full-framework-upgrade",\n      "metric": "p50_latency",\n      "value": 1200.0\n    },\n    {\n      "test_name": "framework_upgrade::framework-upgrade::full-framework-upgrade",\n      "metric": "p90_latency",\n      "value": 1700.0\n    },\n    {\n      "test_name": "framework_upgrade::framework-upgrade::full-framework-upgrade",\n      "metric": "p99_latency",\n      "value": 2100.0\n    }\n  ],\n  "text": "Compatibility test results for 4e5060ed0360038498c14cde6d00f18fe6746672 ==> 1eaa7d33423dc28d54367a8457e855eb5e45b421 (PR)\\nUpgrade the nodes to version: 1eaa7d33423dc28d54367a8457e855eb5e45b421\\nframework_upgrade::framework-upgrade::full-framework-upgrade : committed: 2076.81 txn/s, submitted: 2082.08 txn/s, failed submission: 5.27 txn/s, expired: 5.27 txn/s, latency: 1418.78 ms, (p50: 1400 ms, p70: 1500, p90: 1800 ms, p99: 2400 ms), latency samples: 189063\\nframework_upgrade::framework-upgrade::full-framework-upgrade : committed: 2332.80 txn/s, submitted: 2340.06 txn/s, failed submission: 7.26 txn/s, expired: 7.26 txn/s, latency: 1262.35 ms, (p50: 1200 ms, p70: 1400, p90: 1500 ms, p99: 1800 ms), latency samples: 211980\\n5. check swarm health\\nCompatibility test for 4e5060ed0360038498c14cde6d00f18fe6746672 ==> 1eaa7d33423dc28d54367a8457e855eb5e45b421 passed\\nUpgrade the remaining nodes to version: 1eaa7d33423dc28d54367a8457e855eb5e45b421\\nframework_upgrade::framework-upgrade::full-framework-upgrade : committed: 2310.21 txn/s, submitted: 2317.46 txn/s, failed submission: 7.26 txn/s, expired: 7.26 txn/s, latency: 1266.92 ms, (p50: 1200 ms, p70: 1500, p90: 1700 ms, p99: 2100 ms), latency samples: 210161\\nTest Ok"\n}'
Trailing Log Lines:
Compatibility test results for 4e5060ed0360038498c14cde6d00f18fe6746672 ==> 1eaa7d33423dc28d54367a8457e855eb5e45b421 (PR)
Upgrade the nodes to version: 1eaa7d33423dc28d54367a8457e855eb5e45b421
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 2076.81 txn/s, submitted: 2082.08 txn/s, failed submission: 5.27 txn/s, expired: 5.27 txn/s, latency: 1418.78 ms, (p50: 1400 ms, p70: 1500, p90: 1800 ms, p99: 2400 ms), latency samples: 189063
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 2332.80 txn/s, submitted: 2340.06 txn/s, failed submission: 7.26 txn/s, expired: 7.26 txn/s, latency: 1262.35 ms, (p50: 1200 ms, p70: 1400, p90: 1500 ms, p99: 1800 ms), latency samples: 211980
5. check swarm health
Compatibility test for 4e5060ed0360038498c14cde6d00f18fe6746672 ==> 1eaa7d33423dc28d54367a8457e855eb5e45b421 passed
Upgrade the remaining nodes to version: 1eaa7d33423dc28d54367a8457e855eb5e45b421
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 2310.21 txn/s, submitted: 2317.46 txn/s, failed submission: 7.26 txn/s, expired: 7.26 txn/s, latency: 1266.92 ms, (p50: 1200 ms, p70: 1500, p90: 1700 ms, p99: 2100 ms), latency samples: 210161
Test Ok

=== BEGIN JUNIT ===
<?xml version="1.0" encoding="UTF-8"?>
<testsuites name="forge" tests="1" failures="0" errors="0" uuid="2658f43d-bc9e-4dd2-bf2a-70a31e1dc2e6">
    <testsuite name="local" tests="1" disabled="0" errors="0" failures="0">
        <testcase name="framework_upgrade::framework-upgrade">
        </testcase>
    </testsuite>
</testsuites>
=== END JUNIT ===
[2026-01-08T21:43:05Z INFO  aptos_forge::backend::k8s::cluster_helper] Deleting namespace forge-framework-upgrade-pr-18382: Some(NamespaceStatus { conditions: None, phase: Some("Terminating") })
[2026-01-08T21:43:05Z INFO  aptos_forge::backend::k8s::cluster_helper] aptos-node resources for Forge removed in namespace: forge-framework-upgrade-pr-18382

test result: ok. 1 passed; 0 soft failed; 0 hard failed; 0 filtered out

Debugging output:
NAME                                         READY   STATUS      RESTARTS   AGE
aptos-node-0-validator-0                     1/1     Running     0          11m
aptos-node-1-validator-0                     1/1     Running     0          10m
aptos-node-2-validator-0                     1/1     Running     0          3m12s
aptos-node-3-validator-0                     1/1     Running     0          2m32s
forge-testnet-deployer-fxqzg                 0/1     Completed   0          14m
genesis-aptos-genesis-eforge138641a0-dkjqk   0/1     Completed   0          14m

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking