Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
This PR removes the Spanish (es) documentation set and disables Spanish as a selectable/served locale in the site configuration.
Changes:
- Deleted the Spanish docs tree under
src/content/docs/es/**. - Disabled
esin language configuration (i18n.ts,middleware.js,languages.ts). - Updated the sidebar audit script to no longer special-case the
esfolder.
Reviewed changes
Copilot reviewed 130 out of 353 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/content/docs/es/404.mdx | Removes Spanish localized 404 page. |
| src/content/docs/es/build/aips.mdx | Removes Spanish AIPs landing page. |
| src/content/docs/es/build/aips/aip-88.mdx | Removes Spanish AIP-88 doc page. |
| src/content/docs/es/build/aips/aip-115.mdx | Removes Spanish AIP-115 doc page. |
| src/content/docs/es/build/ai.mdx | Removes Spanish AI tools overview page. |
| src/content/docs/es/build/ai/aptos-mcp.mdx | Removes Spanish Aptos MCP overview page. |
| src/content/docs/es/build/ai/aptos-mcp/claude.mdx | Removes Spanish Claude Code MCP setup page. |
| src/content/docs/es/build/ai/aptos-mcp/cursor.mdx | Removes Spanish Cursor MCP setup page. |
| src/content/docs/es/build/apis.mdx | Removes Spanish APIs overview page. |
| src/content/docs/es/build/apis/aptos-labs-developer-portal.mdx | Removes Spanish Geomi portal page. |
| src/content/docs/es/build/apis/data-providers.mdx | Removes Spanish data providers page. |
| src/content/docs/es/build/apis/faucet-api.mdx | Removes Spanish faucet API page. |
| src/content/docs/es/build/apis/fullnode-rest-api.mdx | Removes Spanish fullnode REST API page. |
| src/content/docs/es/build/apis/fullnode-rest-api-reference.mdx | Removes Spanish REST API reference stub page. |
| src/content/docs/es/build/cli.mdx | Removes Spanish CLI overview page. |
| src/content/docs/es/build/cli/formatting-move-contracts.mdx | Removes Spanish Move formatting page. |
| src/content/docs/es/build/cli/install-cli/install-cli-asdf.mdx | Removes Spanish ASDF/Mise install page. |
| src/content/docs/es/build/cli/install-cli/install-cli-linux.mdx | Removes Spanish Linux CLI install page. |
| src/content/docs/es/build/cli/install-cli/install-cli-mac.mdx | Removes Spanish macOS CLI install page. |
| src/content/docs/es/build/cli/install-cli/install-cli-specific-version.mdx | Removes Spanish specific-version install page. |
| src/content/docs/es/build/cli/install-cli/install-cli-windows.mdx | Removes Spanish Windows CLI install page. |
| src/content/docs/es/build/cli/managing-a-network-node.mdx | Removes Spanish node management page. |
| src/content/docs/es/build/cli/public-network.mdx | Removes Spanish public network guide. |
| src/content/docs/es/build/cli/replay-past-transactions.mdx | Removes Spanish replay transactions page. |
| src/content/docs/es/build/cli/setup-cli.mdx | Removes Spanish CLI setup page. |
| src/content/docs/es/build/cli/setup-cli/install-move-prover.mdx | Removes Spanish Move Prover install page. |
| src/content/docs/es/build/cli/start-from-template.mdx | Removes Spanish template start page. |
| src/content/docs/es/build/cli/trying-things-on-chain.mdx | Removes Spanish on-chain experimentation page. |
| src/content/docs/es/build/cli/trying-things-on-chain/create-test-accounts.mdx | Removes Spanish create test accounts page. |
| src/content/docs/es/build/cli/trying-things-on-chain/ledger.mdx | Removes Spanish Ledger guide page. |
| src/content/docs/es/build/cli/working-with-move-contracts/local-simulation-benchmarking-and-gas-profiling.mdx | Removes Spanish local simulation/benchmarking page. |
| src/content/docs/es/build/cli/working-with-move-contracts/multi-signature-tutorial.mdx | Removes Spanish multisig tutorial page. |
| src/content/docs/es/build/create-aptos-dapp.mdx | Removes Spanish create-aptos-dapp page. |
| src/content/docs/es/build/create-aptos-dapp/faq.mdx | Removes Spanish create-aptos-dapp FAQ page. |
| src/content/docs/es/build/external-resources.mdx | Removes Spanish external resources page. |
| src/content/docs/es/build/get-started.mdx | Removes Spanish getting started page. |
| src/content/docs/es/build/get-started/solana-cheatsheet.mdx | Removes Spanish Solana migration cheatsheet. |
| src/content/docs/es/build/guides.mdx | Removes Spanish guides landing page. |
| src/content/docs/es/build/guides/aptos-keyless.mdx | Removes Spanish Keyless landing page. |
| src/content/docs/es/build/guides/aptos-keyless/other.mdx | Removes Spanish Keyless terminology/FAQ page. |
| src/content/docs/es/build/guides/aptos-keyless/simple-example.mdx | Removes Spanish Keyless simple example page. |
| src/content/docs/es/build/guides/aptos-keyless/federated-keyless/other.mdx | Removes Spanish federated keyless FAQ page. |
| src/content/docs/es/build/guides/build-e2e-dapp.mdx | Removes Spanish E2E dapp guide overview page. |
| src/content/docs/es/build/guides/build-e2e-dapp/2-set-up-the-frontend.mdx | Removes Spanish E2E dapp chapter 2. |
| src/content/docs/es/build/guides/build-e2e-dapp/3-fetch-data-from-chain.mdx | Removes Spanish E2E dapp chapter 3. |
| src/content/docs/es/build/guides/build-e2e-dapp/4-submit-data-to-chain.mdx | Removes Spanish E2E dapp chapter 4. |
| src/content/docs/es/build/guides/orderless-transactions.mdx | Removes Spanish orderless transactions guide. |
| src/content/docs/es/build/guides/sponsored-transactions.mdx | Removes Spanish sponsored transactions guide. |
| src/content/docs/es/build/indexer.mdx | Removes Spanish indexer landing page. |
| src/content/docs/es/build/indexer/indexer-api.mdx | Removes Spanish indexer API access page. |
| src/content/docs/es/build/indexer/indexer-api/account-transactions.mdx | Removes Spanish indexer account transactions page. |
| src/content/docs/es/build/indexer/indexer-api/ans-lookup.mdx | Removes Spanish ANS lookup page. |
| src/content/docs/es/build/indexer/indexer-api/architecture.mdx | Removes Spanish indexer architecture page. |
| src/content/docs/es/build/indexer/indexer-api/fungible-asset-balances.mdx | Removes Spanish fungible asset balances page. |
| src/content/docs/es/build/indexer/indexer-api/fungible-asset-info.mdx | Removes Spanish fungible asset info page. |
| src/content/docs/es/build/indexer/indexer-api/get-delegators.mdx | Removes Spanish delegators query page. |
| src/content/docs/es/build/indexer/indexer-api/get-nft-collections.mdx | Removes Spanish NFT collections page. |
| src/content/docs/es/build/indexer/indexer-api/get-nfts.mdx | Removes Spanish owned NFTs page. |
| src/content/docs/es/build/indexer/indexer-api/self-hosted.mdx | Removes Spanish indexer API self-hosted page. |
| src/content/docs/es/build/indexer/indexer-api/token-metadata.mdx | Removes Spanish token metadata page. |
| src/content/docs/es/build/indexer/indexer-sdk.mdx | Removes Spanish indexer SDK landing page. |
| src/content/docs/es/build/indexer/indexer-sdk/quickstart.mdx | Removes Spanish SDK quickstart page. |
| src/content/docs/es/build/indexer/indexer-sdk/advanced-tutorials/test-transactions.mdx | Removes Spanish SDK test framework overview page. |
| src/content/docs/es/build/indexer/indexer-sdk/documentation.mdx | Removes Spanish SDK documentation landing page. |
| src/content/docs/es/build/indexer/indexer-sdk/documentation/advanced-tutorials.mdx | Removes Spanish SDK advanced tutorials stub page. |
| src/content/docs/es/build/indexer/indexer-sdk/documentation/connect-steps.mdx | Removes Spanish connect steps page. |
| src/content/docs/es/build/indexer/indexer-sdk/documentation/create-processor.mdx | Removes Spanish create processor page. |
| src/content/docs/es/build/indexer/indexer-sdk/documentation/define-schema.mdx | Removes Spanish define schema page. |
| src/content/docs/es/build/indexer/indexer-sdk/documentation/run-processor.mdx | Removes Spanish run processor page. |
| src/content/docs/es/build/indexer/indexer-sdk/documentation/setup.mdx | Removes Spanish setup page. |
| src/content/docs/es/build/indexer/indexer-sdk/documentation/steps.mdx | Removes Spanish steps overview page. |
| src/content/docs/es/build/indexer/indexer-sdk/documentation/version-tracking.mdx | Removes Spanish version tracking page. |
| src/content/docs/es/build/indexer/indexer-sdk/documentation/steps/parsing-txns.mdx | Removes Spanish parsing txns page. |
| src/content/docs/es/build/indexer/indexer-sdk/documentation/steps/transaction-stream.mdx | Removes Spanish transaction stream step page. |
| src/content/docs/es/build/indexer/legacy.mdx | Removes Spanish legacy indexer landing page. |
| src/content/docs/es/build/indexer/legacy/indexer-fullnode.mdx | Removes Spanish legacy indexer fullnode page. |
| src/content/docs/es/build/indexer/legacy/migration.mdx | Removes Spanish legacy migration page. |
| src/content/docs/es/build/indexer/nft-aggregator.mdx | Removes Spanish NFT aggregator landing page. |
| src/content/docs/es/build/indexer/nft-aggregator/analytics-api.mdx | Removes Spanish NFT analytics REST page. |
| src/content/docs/es/build/indexer/nft-aggregator/graphql-api.mdx | Removes Spanish NFT GraphQL page. |
| src/content/docs/es/build/indexer/nft-aggregator/marketplaces.mdx | Removes Spanish NFT marketplaces index page. |
| src/content/docs/es/build/indexer/nft-aggregator/marketplaces/bluemove.mdx | Removes Spanish Bluemove marketplace page. |
| src/content/docs/es/build/indexer/nft-aggregator/marketplaces/rarible.mdx | Removes Spanish Rarible marketplace page. |
| src/content/docs/es/build/indexer/nft-aggregator/marketplaces/topaz.mdx | Removes Spanish Topaz marketplace page. |
| src/content/docs/es/build/indexer/nft-aggregator/marketplaces/tradeport.mdx | Removes Spanish Tradeport marketplace page. |
| src/content/docs/es/build/indexer/nft-aggregator/marketplaces/wapal.mdx | Removes Spanish Wapal marketplace page. |
| src/content/docs/es/build/indexer/txn-stream.mdx | Removes Spanish transaction stream landing page. |
| src/content/docs/es/build/indexer/txn-stream/aptos-hosted-txn-stream.mdx | Removes Spanish hosted txn stream page. |
| src/content/docs/es/build/indexer/txn-stream/local-development.mdx | Removes Spanish local development page. |
| src/content/docs/es/build/indexer/txn-stream/self-hosted.mdx | Removes Spanish self-hosted txn stream page. |
| languages.ts | Disables es (and also ja) in language list(s). |
| middleware.js | Disables es in request-language handling. |
| scripts/audit-sidebar.ts | Updates doc traversal to no longer skip es directory. |
| src/config/i18n.ts | Disables es in supported language config and site titles. |
Comments suppressed due to low confidence (1)
middleware.js:1
- The middleware maintains its own
SUPPORTED_LANGUAGESlist, and the PR disables Spanish via commented-out code. Prefer deleting theesobject here (instead of commenting), and consider sourcing this list from the same shared config assrc/config/i18n.tsto avoid future mismatches.
var __create = Object.create;
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
languages.ts
Outdated
| //es: "Español", | ||
| zh: "简体中文", | ||
| ja: "日本語", | ||
| //ja: "日本語", |
There was a problem hiding this comment.
This PR is scoped to removing Spanish docs, but ja is also being disabled here. If Japanese is intentionally being removed, it should be done consistently (and reflected in PR scope); otherwise, revert the ja change. Also, twoLanguages now contains only one language, so the name/comment are misleading—either restore the second language entry used for smoke tests or rename/update the comment accordingly.
| // Build for two languages only to speed up Astro's smoke tests | ||
| const twoLanguages = { | ||
| en: "English", | ||
| es: "Español", | ||
| // es: "Español", | ||
| } as const; |
There was a problem hiding this comment.
This PR is scoped to removing Spanish docs, but ja is also being disabled here. If Japanese is intentionally being removed, it should be done consistently (and reflected in PR scope); otherwise, revert the ja change. Also, twoLanguages now contains only one language, so the name/comment are misleading—either restore the second language entry used for smoke tests or rename/update the comment accordingly.
| export const SUPPORTED_LANGUAGES: SupportedLanguage[] = [ | ||
| { code: "en", label: "English", default: true }, | ||
| { code: "es", label: "Español" }, | ||
| //{ code: "es", label: "Español" }, | ||
| { code: "zh", label: "简体中文" }, | ||
| ]; | ||
|
|
||
| // Site titles for each supported language | ||
| export const SITE_TITLES: Record<string, string> = { | ||
| en: "Aptos Documentation", | ||
| es: "Documentación de Aptos", | ||
| //es: "Documentación de Aptos", | ||
| zh: "Aptos 文档", | ||
| }; |
There was a problem hiding this comment.
Rather than commenting out locale entries, remove them entirely (and keep formatting consistent). Commented-out config tends to linger and can be re-enabled accidentally; deleting es entries cleanly better matches the intent of removing Spanish support.
| if (file !== "zh") { | ||
| results = results.concat(getDocFiles(filePath)); | ||
| } |
There was a problem hiding this comment.
getDocFiles hard-codes locale folder exclusions. Now that es is removed, this is less urgent, but the pattern is brittle—adding/removing locales requires code edits. Consider replacing the hard-coded check with a set of locale directory names derived from the same language config used elsewhere (e.g., SUPPORTED_LANGUAGES.map(l => l.code)), and skip any directory matching a supported locale folder.
|
@cursoragent rebase, and remove the rest of the spanish docs please. |
|
Here's what I did:
All lint and format checks pass. PR #392 has been updated. |
Unfortunately, the spanish docs haven't had much traction, and require regular translation maitainence which we haven't done. I'm removing them for now.
Remove 3 remaining Spanish doc files under kotlin-sdk that were added after the initial removal commit.
- Remove commented-out es entries from languages.ts, middleware.js, and i18n.ts - Restore ja (Japanese) in languages.ts that was accidentally disabled - Remove /es routes from middleware matcher - Update twoLanguages to use zh instead of commented-out es
7984ce5 to
eb0ed10
Compare


Unfortunately, the spanish docs haven't had much traction, and require regular translation maintenance which we haven't done. I'm removing them for now.
Changes
Spanish docs removal
src/content/docs/es/(including 3 remaining files from recent Kotlin SDK updates)src/content/nav/es.ts)Config cleanup (addressing review feedback)
esentries entirely fromlanguages.ts,middleware.js, andsrc/config/i18n.ts(instead of leaving them commented)ja(Japanese) inlanguages.tswhich was accidentally disabled/esroutes from middleware matchertwoLanguagessmoke test config to usezhinstead of commented-outesscripts/audit-sidebar.tsto no longer special-case theesfolder