Skip to content

Conversation

lightmark
Copy link
Contributor

as title

@lightmark lightmark force-pushed the add_aa_sig branch 3 times, most recently from c43b5ac to aff4f8a Compare September 23, 2025 12:14
@lightmark lightmark requested review from rtso and yuunlimm September 29, 2025 20:30
@rtso
Copy link
Contributor

rtso commented Sep 29, 2025

please add an integration test

@lightmark
Copy link
Contributor Author

added

@rtso rtso requested a review from ying-w October 1, 2025 19:14
Copy link
Contributor

@rtso rtso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, @ying-w can you review this too?

"signer": "0x272c396814beae314a32108c27ff33d845b064b667bde67483e5c6572c8dcf80",
"is_sender_primary": true,
"type_": "abstraction_signature",
"public_key": "Not implemented",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change this to 'not applicable'

"account_public_key": "0xdc9da6abd59694d9d5699b4ec6e24fe18bfc08cfb68b1f0f1b73b58f1753ab6f557b540c9347b8215962ac70c7b153dfd7865ae7348633d16343d1743d923a07aa90e0d9d16b63ba4a289fb0dc8d1b450000000000000000000000000000000002",
"is_public_key_used": true,
"last_transaction_version": 3091258105,
"signature_type": "multi_ed25519_signature"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we have diffs up here? Is the ordering non deterministic?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants