-
Notifications
You must be signed in to change notification settings - Fork 12
Parse AA signature #137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Parse AA signature #137
Conversation
c43b5ac
to
aff4f8a
Compare
please add an integration test |
aff4f8a
to
39ac528
Compare
added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, @ying-w can you review this too?
"signer": "0x272c396814beae314a32108c27ff33d845b064b667bde67483e5c6572c8dcf80", | ||
"is_sender_primary": true, | ||
"type_": "abstraction_signature", | ||
"public_key": "Not implemented", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you change this to 'not applicable'
"account_public_key": "0xdc9da6abd59694d9d5699b4ec6e24fe18bfc08cfb68b1f0f1b73b58f1753ab6f557b540c9347b8215962ac70c7b153dfd7865ae7348633d16343d1743d923a07aa90e0d9d16b63ba4a289fb0dc8d1b450000000000000000000000000000000002", | ||
"is_public_key_used": true, | ||
"last_transaction_version": 3091258105, | ||
"signature_type": "multi_ed25519_signature" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we have diffs up here? Is the ordering non deterministic?
as title