[RFC] Support orderless transactions in Indexer #670
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
what's the upstream change and is there an AIP to track this? |
bowenyang007
reviewed
Apr 1, 2025
| "timestamp", | ||
| "version" | ||
| "version", | ||
| "replay_protection_nonce" |
There was a problem hiding this comment.
we have a process to update this. https://app.clickup.com/9011498509/v/dc/8cj13gd-14211/8cj13gd-8791
our oncall might be able to help here though.
bowenyang007
reviewed
Apr 1, 2025
| pub transaction_version: i64, | ||
| pub event_account_address: String, | ||
| pub event_creation_number: i64, | ||
| // Question: Do we need to add a replay_protection_nonce here? |
There was a problem hiding this comment.
no b/c it's not needed for this table anyways.
bowenyang007
reviewed
Apr 1, 2025
| use field_count::FieldCount; | ||
| use serde::{Deserialize, Serialize}; | ||
|
|
||
| // Question: Do we have to add a replay_protection_nonce here? |
There was a problem hiding this comment.
up to you. it's useful for users but if you want it for debugging we could add it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support orderless transactions in Indexer.
To support orderless transactions, in aptos-core repo, we've added a new variant in
TransactionPayloadenum, to additionally store a nonce and multisig address.Also, in aptos.transaction.v1.rs in aptos-core, we've added
ExtraConfigcontaining nonce and multisig address.This PR modifies the indexer to support the changes in transaction structure of UserTransaction.