add coin_store_deletion_event info to event_to_coin_type map #692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lightmark
requested review from
bowenyang007,
gregnazario,
larry-aptos and
rtso
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #692 +/- ##
=======================================
- Coverage 49.6% 49.2% -0.4%
=======================================
Files 252 252
Lines 28526 28711 +185
=======================================
- Hits 14166 14153 -13
- Misses 14360 14558 +198 ☔ View full report in Codecov by Sentry. |
lightmark
force-pushed
the
parse_coin_store_deletion_event
branch
2 times, most recently
from
7ec0087 to
ff04a33
Compare
rtso
reviewed
Jan 23, 2025
Comment on lines
688
to
690
| let coin_store_deletion_event = events.iter().find_map(|event| { | ||
| let event_type = event.type_str.as_str(); | ||
| CoinStoreDeletionEvent::from_event(event_type, &event.data, txn_version) |
There was a problem hiding this comment.
what if there are multiple deletion events in the same txn?
There was a problem hiding this comment.
nice catch. I updated.
|
what happened here? @rtso @bowenyang007 |
|
not sure if we still need this @bowenyang007 |
lightmark
force-pushed
the
parse_coin_store_deletion_event
branch
2 times, most recently
from
902040d to
14c35c9
Compare
lightmark
force-pushed
the
parse_coin_store_deletion_event
branch
from
14c35c9 to
7a9b65a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the to event id to coin type mapping.