Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the release GitHub Actions workflow to support publishing aptos-sdk and aptos-sdk-macros independently (via tag prefixes) or together (via manual dispatch input).
Changes:
- Switch release tag triggers from
v*tosdk-v*andmacros-v*. - Add a
resolvejob plusworkflow_dispatchinput to select which crate(s) to publish. - Split publishing into separate
publish-macrosandpublish-sdkjobs with dependency handling.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+146
to
149
| # If macros was just published, wait for crates.io to index it | ||
| - name: Wait for crates.io indexing | ||
| if: github.event_name == 'push' || (github.event_name == 'workflow_dispatch' && inputs.dry_run != true) | ||
| if: needs.publish-macros.result == 'success' | ||
| run: sleep 120 |
There was a problem hiding this comment.
The indexing wait step runs whenever the publish-macros job result is success, which includes workflow_dispatch dry runs. That adds an unnecessary 120s delay for crate=both dry runs. Consider gating this step on actually publishing (e.g., also require github.event_name == 'push' or inputs.dry_run != true).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.