-
Notifications
You must be signed in to change notification settings - Fork 7
CI multi-platform builds #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -78,6 +78,85 @@ jobs: | |
| - name: Run tests (all features) | ||
| run: cargo test -p aptos-sdk --all-targets --all-features | ||
|
|
||
| test-linux-arm: | ||
| name: Test (Linux ARM64) | ||
| runs-on: ubuntu-24.04-arm | ||
| steps: | ||
| - uses: actions/checkout@v6 | ||
|
|
||
| - name: Install Rust | ||
| uses: dtolnay/rust-toolchain@master | ||
| with: | ||
| toolchain: stable | ||
|
|
||
| - name: Cache cargo | ||
| uses: Swatinem/rust-cache@v2 | ||
|
|
||
| - name: Build | ||
| run: cargo build -p aptos-sdk --all-targets | ||
|
|
||
| - name: Run tests | ||
| run: cargo test -p aptos-sdk --all-targets | ||
|
|
||
| - name: Run tests (all features) | ||
| run: cargo test -p aptos-sdk --all-targets --all-features | ||
|
|
||
| test-macos-intel: | ||
| name: Test (macOS x86) | ||
| runs-on: macos-15-intel | ||
| steps: | ||
| - uses: actions/checkout@v6 | ||
|
|
||
|
Comment on lines
+104
to
+109
|
||
| - name: Install Rust | ||
| uses: dtolnay/rust-toolchain@master | ||
| with: | ||
| toolchain: stable | ||
|
|
||
| - name: Cache cargo | ||
| uses: Swatinem/rust-cache@v2 | ||
|
|
||
| - name: Build | ||
| run: cargo build -p aptos-sdk --all-targets | ||
|
|
||
| - name: Run tests | ||
| run: cargo test -p aptos-sdk --all-targets | ||
|
|
||
| - name: Run tests (all features) | ||
| run: cargo test -p aptos-sdk --all-targets --all-features | ||
|
|
||
| test-no-simd: | ||
| name: Test (Linux No SIMD - Docker Compatible) | ||
| runs-on: ubuntu-latest | ||
| env: | ||
| # Disable BLST assembly optimizations for portability | ||
| BLST_PORTABLE: "1" | ||
| # Target baseline x86-64 without AVX/AVX2 SIMD extensions. | ||
| # This simulates running in a Docker container on macOS ARM via | ||
| # QEMU x86 emulation, where advanced SIMD instructions are unavailable. | ||
| RUSTFLAGS: "-C target-cpu=x86-64" | ||
|
Comment on lines
+127
to
+136
|
||
| steps: | ||
| - uses: actions/checkout@v6 | ||
|
|
||
| - name: Install Rust | ||
| uses: dtolnay/rust-toolchain@master | ||
| with: | ||
| toolchain: stable | ||
|
|
||
| - name: Cache cargo | ||
| uses: Swatinem/rust-cache@v2 | ||
|
|
||
| - name: Build (default features) | ||
| run: cargo build -p aptos-sdk --all-targets | ||
|
|
||
| - name: Run tests (default features) | ||
| run: cargo test -p aptos-sdk --all-targets | ||
|
|
||
| - name: Build (all features) | ||
| run: cargo build -p aptos-sdk --all-targets --all-features | ||
|
|
||
| - name: Run tests (all features) | ||
| run: cargo test -p aptos-sdk --all-targets --all-features | ||
|
|
||
| test-features: | ||
| name: Test Feature Combinations | ||
| runs-on: ubuntu-latest | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test-linux-armduplicates the same checkout/toolchain/cache/build/test steps already defined in the existingtestjob. This increases maintenance overhead (every future change to the test steps must be replicated across multiple jobs). Consider extending the existingtestmatrix (e.g., withinclude) to cover the ARM runner instead of defining a separate job, unless there’s a runner-specific deviation you need here.