Skip to content

Ci documentation deployment #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gregnazario wants to merge 1 commit into from
Closed

Ci documentation deployment #36

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,6 +242,7 @@ jobs:
contents: read
pages: write
id-token: write
actions: write
Copy link

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The actions: write permission is broader than necessary for GitHub Pages deployment. This permission allows the workflow to modify workflow files and other actions in the repository.

If the enablement: true parameter (line 270) is intended to automatically enable GitHub Pages, this permission is required. However, if GitHub Pages is already manually enabled in the repository settings, you can remove both the actions: write permission and the enablement: true parameter to follow the principle of least privilege.

Consider manually enabling GitHub Pages in the repository settings (Settings → Pages → Source: GitHub Actions) and removing these additions to minimize security risk.

Copilot uses AI. Check for mistakes.
environment:
name: github-pages
url: ${{ steps.deployment.outputs.page_url }}
Expand All @@ -265,6 +266,8 @@ jobs:

- name: Setup Pages
uses: actions/configure-pages@v5
with:
enablement: true
Comment on lines +269 to +270
Copy link

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The enablement: true parameter is used to automatically enable GitHub Pages via the workflow. However, this requires the actions: write permission (added at line 245) which grants broad access to modify repository actions and workflows.

For better security, consider manually enabling GitHub Pages in the repository settings (Settings → Pages → Source: GitHub Actions) and removing this parameter. The actions/configure-pages@v5 action will work without this parameter when Pages is already enabled, requiring only the pages: write and id-token: write permissions that are already present.

Copilot uses AI. Check for mistakes.

- name: Upload artifact
uses: actions/upload-pages-artifact@v4
Expand Down
Loading