Conversation
Upgrade aws-lc-sys from 0.37.1 to 0.38.0 (with aws-lc-rs 1.16.0 → 1.16.1) and pin it as a direct dependency to ensure it stays at 0.38.0+. Bump aptos-sdk 0.4.0 → 0.4.1 and aptos-sdk-macros 0.2.0 → 0.2.1.
There was a problem hiding this comment.
Pull request overview
Upgrades the AWS-LC Rust bindings used by the SDK, and bumps the aptos-sdk / aptos-sdk-macros patch versions to ship the dependency update.
Changes:
- Bump
aptos-sdkto 0.4.1 andaptos-sdk-macrosto 0.2.1, with corresponding changelog entries. - Add
aws-lc-sys = 0.38.0to workspace deps and pin it as a direct dependency ofaptos-sdk. - Update
Cargo.lockto reflectaws-lc-rs1.16.1 andaws-lc-sys0.38.0.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| crates/aptos-sdk/Cargo.toml | Bumps crate version and adds a direct aws-lc-sys dependency. |
| crates/aptos-sdk/CHANGELOG.md | Adds 0.4.1 release notes documenting the upgrade/pin. |
| crates/aptos-sdk-macros/Cargo.toml | Bumps macros crate version to align with SDK release. |
| crates/aptos-sdk-macros/CHANGELOG.md | Adds 0.2.1 release notes documenting the bump. |
| Cargo.toml | Updates workspace crate versions and adds aws-lc-sys = 0.38.0 to workspace deps. |
| Cargo.lock | Locks aws-lc-rs/aws-lc-sys upgrades and new direct dep edge. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
| ## [0.2.1] - 2026-03-04 | ||
|
|
There was a problem hiding this comment.
The changelog adds a new ## [0.2.1] reference-style header but doesn’t add a corresponding [0.2.1]: ... link definition at the bottom (older versions like [0.2.0] and [0.1.0] have definitions). Add the 0.2.1 link definition or remove the brackets to avoid a dangling reference.
| aptos-bcs = { workspace = true } | ||
| aws-lc-sys = { workspace = true } | ||
| thiserror = { workspace = true } |
There was a problem hiding this comment.
aws-lc-sys is added as a non-optional direct dependency, but it doesn’t appear to be used directly by aptos-sdk (it’s only needed transitively for the optional keyless feature via jsonwebtoken’s aws_lc_rs). As written, this will force all aptos-sdk consumers (even without keyless) to build the aws-lc-sys C toolchain dependency, increasing compile time and potentially breaking platforms that can’t build it. Consider making aws-lc-sys an optional dependency and including dep:aws-lc-sys under the keyless feature (or otherwise gating it) so only keyless builds pull it in while still constraining the version when needed.
|
|
||
| ## [unreleased] | ||
|
|
||
| ## [0.4.1] - 2026-03-04 |
There was a problem hiding this comment.
The changelog introduces a new ## [0.4.1] reference-style header but there is no [0.4.1]: ... link definition at the bottom (while older releases like [0.4.0] and [0.1.0] do have link definitions). Either add a link definition for 0.4.1 (consistent with the existing release links) or remove the square brackets so it’s not a dangling reference.
| ## [0.4.1] - 2026-03-04 | |
| ## 0.4.1 - 2026-03-04 |
Summary
aws-lc-sysfrom 0.37.1 to 0.38.0 (viaaws-lc-rs1.16.0 → 1.16.1)aws-lc-sysas a direct dependency inaptos-sdkto ensure it stays at 0.38.0+aptos-sdk0.4.0 → 0.4.1 andaptos-sdk-macros0.2.0 → 0.2.1Test plan
cargo build -p aptos-sdk --all-featurespassescargo test -p aptos-sdk --all-featurespasses (884 unit tests + 31 doc tests)cargo clippy -p aptos-sdk --all-features -- -D warningscleancargo fmt -- --checkclean