Add multi-agent simulation specifications and TypeScript steps#30
Add multi-agent simulation specifications and TypeScript steps#30
Conversation
There was a problem hiding this comment.
Pull request overview
This PR expands the transaction simulation specification to cover multi-agent / fee-payer signer public key inputs (including optional and partial auth-key checks), and adds/updates TypeScript cucumber scenarios + step definitions to match the new spec semantics. It also refreshes TypeScript test status/coverage documentation to reflect the updated scenario counts.
Changes:
- Updated simulation spec to make
sender_public_keyoptional and documented multi-agent/fee-payer signer public key inputs + validation requirements. - Added new simulation.feature scenarios for multi-agent + fee-payer simulation key-handling semantics and implemented corresponding TypeScript steps.
- Updated TypeScript SDK test status and overall feature coverage counts to reflect the new scenarios.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/typescript/steps/simulation.steps.ts | Adds step definitions for multi-agent/fee-payer simulation public-key semantics and a new malformed-mapping validation path. |
| tests/typescript/SDK_STATUS.md | Updates “Last Updated/Verified” metadata and scenario/step counts from a dry-run summary. |
| specifications/07-advanced-features.md | Updates simulation API shape (optional sender key) and specifies multi-agent/fee-payer simulation input rules. |
| features/06-advanced/spec.md | Adds a concise “Transaction Simulation Semantics” section capturing the new rules. |
| features/06-advanced/simulation.feature | Expands simulation scenarios to cover multi-agent/fee-payer auth-key check modes and malformed input rejection. |
| FEATURE_COVERAGE.md | Updates scenario totals and breaks simulation coverage into more granular items reflecting new scenarios. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
There was a problem hiding this comment.
Pull request overview
This PR updates the advanced-features specification and the TypeScript Cucumber suite to introduce/expand multi-agent + fee-payer simulation semantics, including optional signer public keys and stricter input validation expectations.
Changes:
- Specify optional
sender_public_keyfor simulation and add P1 rules for multi-agent/fee-payer simulation signer key inputs (including partial checks and malformed mapping validation). - Add/adjust TypeScript Cucumber steps and scenarios to cover the new simulation semantics and update simulation result assertions to handle multiple result shapes.
- Refresh status/coverage documentation to reflect the new simulation scenarios and updated dry-run counts.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/typescript/steps/simulation.steps.ts | Adds multi-agent/fee-payer simulation-related step definitions, expands result-resolution logic, and introduces malformed signer-key mapping validation in the “try to simulate” path. |
| tests/typescript/SDK_STATUS.md | Updates “Last Updated/Verified” dates and adjusts scenario/step counts to reflect spec/test additions. |
| specifications/07-advanced-features.md | Makes sender_public_key optional for simulation and adds multi-agent/fee-payer simulation input requirements + scenario count update. |
| features/06-advanced/spec.md | Adds a P1 “Transaction Simulation Semantics” section describing multi-agent/fee-payer simulation rules. |
| features/06-advanced/simulation.feature | Expands simulation scenarios to cover signer-public-key presence/absence/partial checks and malformed mapping validation. |
| FEATURE_COVERAGE.md | Updates simulation totals and breaks out multi-agent/fee-payer simulation rows in the coverage matrix. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
There was a problem hiding this comment.
Pull request overview
This PR expands the transaction simulation specification to cover multi-agent and fee-payer semantics (including optional/partial auth-key checks), and updates the TypeScript Cucumber steps + feature scenarios to exercise those rules.
Changes:
- Add new preferred simulation scenarios for multi-agent + fee-payer auth-key check modes (full / skipped / partial) and malformed key mapping validation.
- Extend TypeScript simulation step definitions to support the new scenarios and to accept either
simulationResponseorsimulationResultshapes. - Update spec/coverage/status documentation to reflect the new simulation scenarios and current dry-run counts.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/typescript/steps/simulation.steps.ts | Adds step definitions for multi-agent + fee-payer simulation auth-key check scenarios and improves simulation result resolution. |
| tests/typescript/SDK_STATUS.md | Updates “last verified” metadata and scenario/step counts; notes targeted multi-agent simulation run. |
| specifications/07-advanced-features.md | Makes sender_public_key optional and specifies multi-agent/fee-payer simulation input rules + validation requirements. |
| features/06-advanced/spec.md | Adds preferred-level simulation semantics section (auth-key checks optional; partial checks allowed). |
| features/06-advanced/simulation.feature | Replaces/expands simulation scenarios to cover multi-agent + fee-payer key-check modes and malformed mapping validation. |
| FEATURE_COVERAGE.md | Updates simulation scenario totals and expands simulation checklist entries to match new scenarios. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
There was a problem hiding this comment.
Pull request overview
This PR updates the advanced-features specification to define multi-agent / fee-payer simulation inputs (including optional signer public keys and auth-key check semantics) and expands the TypeScript cucumber feature/step coverage to match those new scenarios, along with status/coverage doc updates.
Changes:
- Add new
simulation.featurescenarios covering multi-agent + fee-payer simulation with full/partial/skipped auth-key checks and malformed key mapping validation. - Extend
simulation.steps.tswith corresponding step definitions and more flexible “simulation should work” result handling. - Update spec + repo status/coverage docs to reflect the new simulation semantics and scenario counts.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/typescript/steps/simulation.steps.ts | Adds TS cucumber steps for multi-agent/fee-payer simulation auth-key-check modes and mapping validation; tweaks result resolution logic. |
| features/06-advanced/simulation.feature | Adds preferred scenarios for the new multi-agent/fee-payer simulation semantics. |
| specifications/07-advanced-features.md | Updates simulation API signature to optional sender key; adds multi-agent/fee-payer simulation input requirements. |
| features/06-advanced/spec.md | Documents preferred simulation semantics at the feature-spec level. |
| tests/typescript/SDK_STATUS.md | Updates verification metadata and dry-run counts/notes for new scenarios. |
| FEATURE_COVERAGE.md | Updates simulation scenario totals and TS coverage counts to reflect the new spec. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
There was a problem hiding this comment.
Pull request overview
Adds specification language and TypeScript Cucumber step coverage for multi-agent / fee-payer transaction simulation semantics, including optional signer public key inputs for auth-key checks and validation behavior.
Changes:
- Expanded simulation spec to allow optional sender public key and to define multi-agent / fee-payer simulation public-key inputs and validation rules.
- Added new
simulation.featurescenarios for multi-agent simulation (full/partial/skipped auth-key checks, malformed key mapping validation, broader changes/events assertions) and fee-payer simulation variants. - Implemented corresponding TypeScript step definitions and ensured fee-payer transaction setup stores a
feePayerTransactionobject for simulation steps.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/typescript/steps/simulation.steps.ts | Adds multi-agent simulation transaction setup + new simulation/auth-key-check related step definitions and validation behavior. |
| tests/typescript/steps/fee-payer.steps.ts | Stores a FeePayerRawTransaction in testVectors for scenarios that simulate fee-payer transactions. |
| tests/typescript/SDK_STATUS.md | Updates “Last Updated/Verified” metadata and scenario/step counts reflecting spec/feature changes. |
| specifications/07-advanced-features.md | Updates simulation API signature (optional sender pubkey) and adds multi-agent/fee-payer simulation input requirements. |
| features/06-advanced/spec.md | Documents preferred simulation semantics, including optional auth-key checks and partial secondary key-slot checks. |
| features/06-advanced/simulation.feature | Adds/updates simulation scenarios for multi-agent + fee-payer simulation behavior. |
| FEATURE_COVERAGE.md | Updates simulation scenario counts and per-scenario coverage entries to reflect the expanded simulation suite. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
There was a problem hiding this comment.
Pull request overview
Adds specification guidance and TypeScript Cucumber step implementations for multi-agent + fee-payer transaction simulation, including optional/partial signer public key (auth-key) checks and malformed key-mapping validation.
Changes:
- Added TS Cucumber steps to build multi-agent simulation transactions and validate auth-key-check behaviors (full/partial/skipped).
- Updated simulation feature scenarios and coverage/docs to reflect new multi-agent simulation cases.
- Updated fee-payer step setup to store a
FeePayerRawTransactionfor downstream simulation steps.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
tests/typescript/steps/simulation.steps.ts |
Adds multi-agent simulation transaction setup and new step definitions for signer key handling + validation. |
tests/typescript/steps/fee-payer.steps.ts |
Persists a feePayerTransaction object to support simulation scenarios. |
tests/typescript/SDK_STATUS.md |
Updates run metadata and scenario counts for the expanded simulation specs. |
specifications/07-advanced-features.md |
Specifies optional signer pubkey inputs for simulation + validation requirements. |
features/06-advanced/spec.md |
Adds concise simulation semantics for multi-agent/fee-payer signer key behavior. |
features/06-advanced/simulation.feature |
Expands simulation scenarios to cover pubkey-provided/skipped/partial/malformed-mapping cases. |
FEATURE_COVERAGE.md |
Updates simulation scenario counts and detailed checklist items to match new specs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
- Added `pnpm-lock.yaml` to manage dependencies. - Refactored transaction payload helper functions into a new file `transaction-payload-helpers.ts`. - Updated various step definitions to utilize the new helper functions for creating entry functions and transfer payloads. - Cleaned up unused imports and functions in step files for better readability.
There was a problem hiding this comment.
Pull request overview
This PR extends the “advanced features” specs and TypeScript Cucumber step implementations to cover multi-agent and fee-payer transaction simulation semantics (including optional/partial signer auth-key checks), and refactors shared transaction-payload construction helpers.
Changes:
- Add new TS helper utilities for building entry functions and standard transfer payloads, and reuse them across step files.
- Expand TypeScript simulation step definitions to cover multi-agent / fee-payer simulation inputs, validation, and result assertions used by new scenarios.
- Update simulation specifications, feature scenarios, and coverage/status docs to reflect the new scenarios and semantics.
Reviewed changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/typescript/support/transaction-payload-helpers.ts | New shared helper for building EntryFunction and transfer payloads reused across steps. |
| tests/typescript/steps/transaction.steps.ts | Switch to the shared createEntryFunction helper; remove old inline builder helpers. |
| tests/typescript/steps/simulation.steps.ts | Add multi-agent + fee-payer simulation steps and validation behaviors used by new scenarios. |
| tests/typescript/steps/multi-agent.steps.ts | Reuse shared transfer payload helper; remove duplicated helper code. |
| tests/typescript/steps/fee-payer.steps.ts | Reuse shared transfer payload helper; store FeePayerRawTransaction for simulation steps. |
| tests/typescript/SDK_STATUS.md | Update scenario counts and verification notes reflecting new simulation scenarios. |
| specifications/07-advanced-features.md | Specify optional public-key inputs for simulation and add multi-agent/fee-payer simulation requirements. |
| features/06-advanced/spec.md | Add a concise “Transaction Simulation Semantics” section for preferred requirements. |
| features/06-advanced/simulation.feature | Add/replace preferred scenarios for multi-agent + fee-payer simulation and key-check modes. |
| FEATURE_COVERAGE.md | Update simulation scenario counts and per-scenario coverage rows. |
| pnpm-lock.yaml | Add pnpm lockfile for prettier-related dev dependencies. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
There was a problem hiding this comment.
Pull request overview
This PR expands the “advanced features” simulation spec to cover multi-agent + fee payer simulation semantics (including optional/partial auth-key checks), and updates the TypeScript Cucumber step suite accordingly, consolidating repeated transaction-payload construction into shared helpers.
Changes:
- Added shared TS helpers to construct
EntryFunctionand standard transfer payloads for use across step definitions. - Extended
simulation.steps.tswith multi-agent and fee-payer simulation scenarios, including validation behavior for malformed signer key mappings. - Updated spec/feature documentation and coverage/status reports to reflect the new simulation scenarios and semantics.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/typescript/support/transaction-payload-helpers.ts | New shared helpers for entry function + transfer payload creation. |
| tests/typescript/steps/transaction.steps.ts | Replaced inline entry-function helper with shared import. |
| tests/typescript/steps/simulation.steps.ts | Added multi-agent/fee-payer simulation setup + assertions for auth-key check modes and mapping validation. |
| tests/typescript/steps/multi-agent.steps.ts | Replaced inline payload helpers with shared import. |
| tests/typescript/steps/fee-payer.steps.ts | Replaced inline payload helpers with shared import; stores feePayerTransaction in composite setup step. |
| tests/typescript/SDK_STATUS.md | Updated run metadata and scenario counts/notes. |
| specifications/07-advanced-features.md | Documented optional sender public key + multi-agent/fee-payer simulation key input rules; updated numbering and scenario count. |
| features/06-advanced/spec.md | Added a concise “Transaction Simulation Semantics” section (P1). |
| features/06-advanced/simulation.feature | Added preferred scenarios for multi-agent/fee-payer simulation auth-key checks and mapping validation. |
| FEATURE_COVERAGE.md | Updated simulation scenario totals and detailed coverage entries. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…latest test results and last updated dates
There was a problem hiding this comment.
Pull request overview
This PR expands the “advanced features” behavioral spec to cover multi-agent / fee-payer transaction simulation semantics (especially around optional auth-key checks) and wires up new/updated TypeScript Cucumber steps to satisfy the new scenarios.
Changes:
- Added spec language and new
simulation.featurescenarios for multi-agent + fee-payer simulation inputs (optional/partial signer public key checks + malformed mapping validation). - Implemented/updated TypeScript step definitions to support the new simulation scenarios and refactored shared transaction-payload construction into a helper module.
- Updated TypeScript/Rust test docs and coverage matrices to reflect the new scenario counts and verification notes.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/typescript/support/transaction-payload-helpers.ts | New shared helpers for building EntryFunction and standard transfer payloads. |
| tests/typescript/steps/transaction.steps.ts | Removes in-file helper and reuses shared payload helper. |
| tests/typescript/steps/transaction-submission.steps.ts | Formatting-only change to transaction hash vector setting. |
| tests/typescript/steps/simulation.steps.ts | Adds multi-agent + fee-payer simulation step coverage and validation behavior for malformed signer key mappings. |
| tests/typescript/steps/multi-agent.steps.ts | Reuses shared transfer payload helper (removes duplicated local helpers). |
| tests/typescript/steps/fee-payer.steps.ts | Reuses shared transfer payload helper and stores a FeePayerRawTransaction for simulation steps. |
| tests/typescript/SDK_STATUS.md | Updates scenario counts/notes and verification metadata. |
| tests/rust/src/steps/network_steps.rs | Formatting-only changes (no logic change). |
| specifications/07-advanced-features.md | Updates simulation signature to allow optional sender key; adds multi-agent/fee-payer simulation input requirements. |
| features/06-advanced/spec.md | Adds P1 “Transaction Simulation Semantics” section. |
| features/06-advanced/simulation.feature | Adds new preferred scenarios for multi-agent + fee-payer simulation auth-key checking behavior. |
| FEATURE_COVERAGE.md | Updates totals and simulation coverage row counts to reflect new scenarios. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
No description provided.