Added subtle hover effect for toast-close and Changed comment style to be able to minify files#87
Open
GeorgeFlorian wants to merge 2 commits intoapvarun:masterfrom
Open
Added subtle hover effect for toast-close and Changed comment style to be able to minify files#87GeorgeFlorian wants to merge 2 commits intoapvarun:masterfrom
GeorgeFlorian wants to merge 2 commits intoapvarun:masterfrom
Conversation
|
@GeorgeFlorian |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I thought of adding a hover effect for
toast-closeclass (the X sign on the toast) to make it more visible on Desktop:Also, since I am using this library on an ESP and I believe I am not the only one, saving memory is of utmost importance so I've changed the comment style from
// commentto/* comment */to be able to minify the files. Also added;were it was missing.Thank you.