Sonatype deploy: use maven versions plugin +semver: feature #50
Conversation
(to set version correctly in pom before package upload)
mialeska
added
enhancement
WalkthroughThe changes update the Maven project configuration and release workflow. The project version is now explicitly set in the Changes
Possibly related PRs
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
mialeska
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
pom.xml (1)
175-179:versions-maven-pluginadded without executionsThe explicit declaration is helpful for IDE completion, but it is unused during a normal
mvn package.
If you want to avoid the extra download for local builds, add<scope>none</scope>or move the plugin configuration to the CI command line:<plugin> <groupId>org.codehaus.mojo</groupId> <artifactId>versions-maven-plugin</artifactId> <version>2.18.0</version> <scope>none</scope> </plugin>Optional, purely a cleanliness concern.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.github/workflows/release-maven-central.yml(1 hunks)pom.xml(4 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: aquality-automation.aquality-appium-mobile-java (Run tests LOCAL_SERVER)
- GitHub Check: aquality-automation.aquality-appium-mobile-java (Run tests REMOTE_SERVER)
- GitHub Check: aquality-automation.aquality-appium-mobile-java (Analyse code with SonarQube)
🔇 Additional comments (3)
pom.xml (3)
9-9: Hard-coding the version may drift out of sync with GitVersion output
<version>5.4.1</version>is now a static value, while the workflow overrides it withmvn versions:set -DnewVersion=${{ steps.gitversion.outputs.semVer }}.
After the first release, the POM inmasterwill still read5.4.1; the next build will again start from that value and GitVersion will bump it relative to 5.4.1, not the true latest release. Over time the declared version in source and the published artefact version will diverge.Consider reinstating the
${revision}placeholder (or another lightweight token) and keeping the canonical version only in GitVersion, e.g.:- <version>5.4.1</version> + <version>${revision}</version> ... <properties> + <revision>0.0.0-SNAPSHOT</revision>This lets local builds keep working while the workflow still calls
versions:set.
Alternative: add a CI step that commits the updated POM back tomasterafter a successful deploy.
63-64: Compiler-plugin bump looks safe
maven-compiler-plugin3.14.0 only adds Java 21 support and minor fixes; no API changes expected. 👍
100-101: Assembly-plugin version update LGTMNo breaking changes between 3.4.x and 3.7.1 that affect the
jar-with-dependenciesgoal.
github-project-automation
bot
moved this from In progress
to Review in progress
in Aquality Appium Mobile
|
github-project-automation
bot
moved this from Review in progress
to Done
in Aquality Appium Mobile
1 participant
(to set version correctly in pom before package upload)