Update Selenium to 4.35.0 +semver:feature #104
Conversation
WalkthroughDependency versions updated in pom.xml: jackson-databind to 2.19.2, selenium-java to 4.35.0, and io.appium:java-client to 10.0.0 (test scope). No public API signature changes reported. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
pom.xml (2)
120-129: Optional: stabilize transitive resolution from Appium by pinning Selenium via properties/dependencyManagement.Maven will prefer your direct selenium-java:4.35.0, but Appium declares a semver-open Selenium range. To avoid future drift in multi-module builds, consider centralizing versions as properties and/or dependencyManagement. This is a nicety, not a blocker. (github.com)
Apply this small refactor to make upgrades simpler:
@@ <properties> <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding> <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> <log4j.version>2.25.1</log4j.version> + <jackson.version>2.19.2</jackson.version> + <selenium.version>4.35.0</selenium.version> + <appium.version>10.0.0</appium.version> </properties> @@ <dependency> <groupId>com.fasterxml.jackson.core</groupId> <artifactId>jackson-databind</artifactId> - <version>2.19.2</version> + <version>${jackson.version}</version> </dependency> @@ <dependency> <groupId>org.seleniumhq.selenium</groupId> <artifactId>selenium-java</artifactId> - <version>4.35.0</version> + <version>${selenium.version}</version> </dependency> @@ <dependency> <groupId>io.appium</groupId> <artifactId>java-client</artifactId> - <version>10.0.0</version> + <version>${appium.version}</version> <scope>test</scope> </dependency>
120-129: Optional: add a quick compatibility check to CI to catch future Selenium/Appium API removals.Because Selenium keeps removing long-deprecated APIs (e.g., LocationContext/WebStorage in 4.35.0), a lightweight grep-based guard in CI can fail fast on future bumps. You can reuse the script above and wire it in a dedicated “dependency bump checks” job. (fossies.org)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
pom.xml(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2024-11-29T13:27:59.820Z
Learnt from: mialeska
PR: aquality-automation/aquality-selenium-core-java#98
File: pom.xml:124-124
Timestamp: 2024-11-29T13:27:59.820Z
Learning: As of November 2024, the latest stable version of `com.fasterxml.jackson.core:jackson-databind` is `2.18.2`, and versions `2.15.x` are outdated.
Applied to files:
pom.xml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: aquality-automation.aquality-selenium-core-java (Analyse code with SonarQube)
- GitHub Check: aquality-automation.aquality-selenium-core-java (Run tests)
🔇 Additional comments (3)
pom.xml (3)
117-117: Jackson to 2.19.2: good, current, and non-vulnerable.This aligns with your past preference to stay on the latest stable Jackson. 2.19.2 is currently listed as the latest and the “latest non vulnerable version.” LGTM. (security.snyk.io)
125-129: Appium Java Client 10.0.0 matches Selenium 4.35.0—scope and pairing look correct.v10.0.0 raises the minimum Selenium to 4.35.0 and removes legacy Location/LocationContext glue, so pairing it with Selenium 4.35.0 (as you did) is correct; keeping it in test scope is also appropriate for this module. (github.com)
120-123: Action Required: Verify Java 11+ Configuration and Selenium API RemovalsOur automated scans did not detect any direct usages of the removed html5/WebStorage APIs in the Java code, but absence of results is not absolute proof. Likewise, we couldn’t locate a configured Java version in your
pom.xml. Please manually verify the following before merging:
pom.xml
• Confirm you have set Java 11 or higher via either a<java.version>property or the Maven Compiler Plugin’s<maven.compiler.source>and<maven.compiler.target>elements.
• Example snippet to look for:<properties> <java.version>11</java.version> </properties> <!-- or --> <plugin> <groupId>org.apache.maven.plugins</groupId> <artifactId>maven-compiler-plugin</artifactId> <configuration> <source>11</source> <target>11</target> </configuration> </plugin>Codebase-wide API usages
• Manually search for any imports or references to:
•org.openqa.selenium.html5.LocationContext
•org.openqa.selenium.html5.Location
•org.openqa.selenium.html5.WebStorage
•org.openqa.selenium.html5.LocalStorage
•org.openqa.selenium.html5.SessionStorage
•org.openqa.selenium.remote.html5.RemoteLocationContext
• If found, refactor to remove or replace with supported alternatives (e.g., Appium Java Client’s Location API).Taking these steps will ensure your upgrade to Selenium 4.35.0 (which removes the deprecated LocationContext/WebStorage APIs) does not introduce compile-time or runtime failures.
PR Details
Related Issue Link:
How Has This Been Tested
Checklist