feat: add GitHub token authentication support#909
Open
azrsh wants to merge 1 commit intoaquaproj:mainfrom
Open
feat: add GitHub token authentication support#909azrsh wants to merge 1 commit intoaquaproj:mainfrom
azrsh wants to merge 1 commit intoaquaproj:mainfrom
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
- Add conditional authentication using GITHUB_TOKEN environment variable - Support Bearer token auth for both curl and wget download methods - Maintain backward compatibility with unauthenticated requests - Provide user feedback when authentication is being used - Enables higher rate limits and potential private repository access Resolves unauthenticated GitHub API requests when token is available.
49b2b26 to
2e4fcca
Compare
Member
|
Line 66 in c780ffb The endpoint isn't GitHub REST API. |
Member
|
If you have any trouble, could you create an issue first? |
Author
|
@suzuki-shunsuke Thank you for your response! We are facing some 403 errors (which is usually the rate limit errors on GitHub), but if the endpoint doesn't have the rate limit, then the cause can be another factor. Let me try to investigate a bit more 🙇 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds optional GitHub token authentication support to the aqua-installer script, enabling authenticated downloads when the
GITHUB_TOKENenvironment variable is available. The action.yaml sets the GITHUB_TOKEN environment variable, so the aqua-installer action user can utilize their token to fetch the aqua binary.This moves the request from IP-address-based GitHub rate limit budget to identity-based one, which has higher rate limits.
https://docs.github.com/en/rest/using-the-rest-api/rate-limits-for-the-rest-api?apiVersion=2022-11-28
Changes Made
Authorization: Bearerheader whenGITHUB_TOKENis setBenefits
Usage
Testing
curlandwget