Skip to content

discovery: Make kubectl.py able to find kubectl #511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
martbhell wants to merge 3 commits into
base: main
Choose a base branch
from
Open

discovery: Make kubectl.py able to find kubectl #511

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
563a11d
discovery: Make kubectl.py able to find kubectl
martbhell Jun 3, 2022
2e50ae0
Use shlex.split in discovery/kubectl.py
martbhell Aug 24, 2022
fc9811b
Import shlex for command parsing
martbhell Aug 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion kube_hunter/modules/discovery/kubectl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ def get_kubectl_binary_version(self):
version = None
try:
# kubectl version --client does not make any connection to the cluster/internet whatsoever.
version_info = subprocess.check_output("kubectl version --client", stderr=subprocess.STDOUT)
version_info = subprocess.check_output(["kubectl", "version", "--client"], stderr=subprocess.STDOUT)
if b"GitVersion" in version_info:
# extracting version from kubectl output
version_info = version_info.decode()
Expand Down