Fix: Convert host to str before adding to node_tables (#469)#530
Open
mckirk wants to merge 1 commit intoaquasecurity:mainfrom
Open
Fix: Convert host to str before adding to node_tables (#469)#530mckirk wants to merge 1 commit intoaquasecurity:mainfrom
mckirk wants to merge 1 commit intoaquasecurity:mainfrom
Conversation
Fixes a crash when `service.host` is an `IPAddress` instead of a string, which results in a `TypeError: '<' not supported between instances of 'str' and 'IPAddress'` when PrettyTable tries to sort the entries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change fixes issue #469, which occurs because
service.hostsometimes is anIPAddressinstead of a string.This resulted in a
TypeError: '<' not supported between instances of 'str' and 'IPAddress'when PrettyTable tries to sort the entries.The fix was to always convert
service.hostto a string before adding it to the table.Maybe this is not the right place to fix this issue, as it might not be intended that
service.hostcan be anIPAddress, but it certainly was the easiest way to get rid of the crash.Fixed Issues
Fixes #469
"BEFORE" and "AFTER" output
BEFORE
AFTER
Crash is gone.
Contribution checklist
Notes
I have not added a test.