-
Notifications
You must be signed in to change notification settings - Fork 478
feat(events): io_uring #5069
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(events): io_uring #5069
Conversation
e2b2e85 to
09314a8
Compare
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (60.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #5069 +/- ##
==========================================
+ Coverage 29.72% 30.09% +0.36%
==========================================
Files 234 232 -2
Lines 26186 25895 -291
==========================================
+ Hits 7785 7793 +8
+ Misses 17864 17565 -299
Partials 537 537
🚀 New features to boost your workflow:
|
07508fb to
ec5eba5
Compare
|
5.4 status: We need some probe to extract the context for write operations. The issue is that io_uring_create has no kernel symbol, and nor does the alternative from the original PR io_sq_offload_start. Both are not defined in any header and therefore do not appear as attachable symbols. The solution is to use the wrapping io_uring_setup. This calls io_uring_create, so 5.5+ will have a slight timing advantage. But we should have fundamentally the same io_uring_params struct result if we attach to the return. |
|
status: the
I think that we must at least do 2 if we are to support fallbacks. Ideally we should give 1. |
1. Explain what the PR does
"Replace me with
make check-proutput"2. Explain how to test it
3. Other comments
Close #309