Conversation
DmitriyLewen
approved these changes
Feb 18, 2026
Contributor
DmitriyLewen
left a comment
There was a problem hiding this comment.
LGTM
left one small comment.
Also, I think, it make sense to change the PR title scope from ghsa to osv.
Contributor
There was a problem hiding this comment.
nit:
Since you are updating the code in the osv package, I think it would be better to add the tests there as well.
CVSS_V4 is a standard OSV severity type.
This is not unique to GHSA, so other sources will also use these new values.
e.g.:
➜ bbolt get ./trivy.db vulnerability CVE-2025-26625 | jq .CVSS
{
"bitnami": {
"V40Vector": "CVSS:4.0/AV:N/AC:L/AT:N/PR:N/UI:P/VC:H/VI:H/VA:N/SC:N/SI:N/SA:N",
"V40Score": 8.6
},
"ghsa": {
"V40Vector": "CVSS:4.0/AV:N/AC:L/AT:N/PR:N/UI:P/VC:H/VI:H/VA:N/SC:N/SI:N/SA:N",
"V40Score": 8.6
},
"redhat": {
"V3Vector": "CVSS:3.1/AV:N/AC:L/PR:N/UI:R/S:U/C:H/I:H/A:N",
"V3Score": 8.1
}
}
CVSS_V4 is a standard OSV severity type, not unique to GHSA. Move the test and test data to the osv package where the parsing logic lives.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CvssScoreV40/CvssVectorV40fields (used by NVD), but the OSV parser only handledCVSS_V3parseSeverityintoparseSeveritiesreturning both V3 and V40 resultstypes.VulnerabilityDetailVerification
Built DB with GHSA data and confirmed CVSSv4 fields are stored: