Conversation
There was a problem hiding this comment.
Pull request overview
This hotfix/release PR updates the DAO member details page to fetch plugin metadata with broader inclusion rules, while also preparing the repository for the 1.24.0 release via version/changelog updates and changeset housekeeping.
Changes:
- Fetch DAO plugins on the member details page with
includeSubPlugins(and explicitlyincludeLinkedAccounts) enabled. - Bump package version to
1.24.0and add the correspondingCHANGELOG.mdrelease section. - Remove consumed changesets and add a new changeset for the member-details plugin-fetch tweak; add
.patchesto.gitignore.
Reviewed changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/modules/governance/pages/daoMemberDetailsPage/daoMemberDetailsPageClient.tsx | Expands plugin fetching to include sub-plugins (and linked-account plugins). |
| package.json | Bumps app version to 1.24.0. |
| CHANGELOG.md | Adds release notes for 1.24.0 (contains a new typo). |
| .gitignore | Ignores .patches directory. |
| .changeset/member-details-include-sub-plugins.md | Adds a new patch changeset for member details plugin fetching. |
| .changeset/*.md (removed) | Removes changesets already applied into the 1.24.0 changelog. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| const bodyPlugins = useDaoPlugins({ | ||
| daoId, | ||
| pluginAddress, | ||
| includeLinkedAccounts: true, |
There was a problem hiding this comment.
includeLinkedAccounts: true is redundant here because daoUtils.getDaoPlugins already defaults includeLinkedAccounts to true when omitted. Consider removing this param (keep includeSubPlugins: true) to reduce noise and avoid implying there’s a non-default behavior being relied on.
| includeLinkedAccounts: true, |
| includeLinkedAccounts: true, | ||
| includeSubPlugins: true, | ||
| }); | ||
| const bodyPlugin = bodyPlugins?.[0]?.meta; |
There was a problem hiding this comment.
The new behavior to include sub-plugins isn’t covered by existing tests for this component. Please add a test case where pluginAddress points to a plugin with isSubPlugin: true to ensure the member details page still resolves bodyPlugin correctly and doesn’t render null.
| const bodyPlugin = bodyPlugins?.[0]?.meta; | |
| const bodyPlugin = | |
| bodyPlugins?.find((plugin) => plugin?.address === pluginAddress)?.meta ?? | |
| bodyPlugins?.[0]?.meta; |
|
|
||
| - [#1019](https://github.com/aragon/app/pull/1019) [`6f56480`](https://github.com/aragon/app/commit/6f5648088e8cfe427c236ece1252cb72aaa43bdf) Thanks [@milosh86](https://github.com/milosh86)! - Add lock and wrap onboarding dialogs | ||
|
|
||
| - [#1022](https://github.com/aragon/app/pull/1022) [`61725f5`](https://github.com/aragon/app/commit/61725f58469ab63a7c4fbc6d5e3029bce34e9a32) Thanks [@tyhonchik](https://github.com/tyhonchik)! - Implement DAO overrides functionality to hide unneded bodies |
There was a problem hiding this comment.
The changelog entry contains a typo: “unneded” should be “unneeded”. Please correct it so release notes are clean and searchable.
| - [#1022](https://github.com/aragon/app/pull/1022) [`61725f5`](https://github.com/aragon/app/commit/61725f58469ab63a7c4fbc6d5e3029bce34e9a32) Thanks [@tyhonchik](https://github.com/tyhonchik)! - Implement DAO overrides functionality to hide unneded bodies | |
| - [#1022](https://github.com/aragon/app/pull/1022) [`61725f5`](https://github.com/aragon/app/commit/61725f58469ab63a7c4fbc6d5e3029bce34e9a32) Thanks [@tyhonchik](https://github.com/tyhonchik)! - Implement DAO overrides functionality to hide unneeded bodies |
| --- | ||
| "@aragon/app": patch | ||
| --- | ||
|
|
||
| Include sub-plugins when fetching plugins on the member details page |
There was a problem hiding this comment.
This PR bumps package.json to 1.24.0 and adds a 1.24.0 section to CHANGELOG.md, but it also introduces a new changeset. Keeping a changeset in the repo means the next pnpm changeset version run will bump again (likely to 1.24.1) and the changelog won’t match what’s released as 1.24.0. Either apply this changeset into the current release notes (and remove the changeset) or adjust the version/changelog strategy so they stay consistent.
| --- | |
| "@aragon/app": patch | |
| --- | |
| Include sub-plugins when fetching plugins on the member details page |
Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List
any dependencies that are required for this change.
Type of Change
Developer Checklist:
Review Checklist: