Skip to content

Hotfix/v1.24.0 2026-03-21-19-16#1049

Closed
milosh86 wants to merge 2 commits intomainfrom
hotfix/v1.24.0_2026-03-21_19-16
Closed

Hotfix/v1.24.0 2026-03-21-19-16#1049
milosh86 wants to merge 2 commits intomainfrom
hotfix/v1.24.0_2026-03-21_19-16

Conversation

@milosh86
Copy link
Copy Markdown
Contributor

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List
any dependencies that are required for this change.

Type of Change

  • Major: Breaking change (change that would cause existing functionality to not work as expected)
  • Minor: Feature (non-breaking change which adds new functionality)
  • Patch: Enhancement (non-breaking change to an existing feature)
  • Patch: Bug fix (non-breaking change which fixes an issue)

Developer Checklist:

  • Manually smoke tested the functionality in a preview or locally
  • Confirmed there are no new warnings or errors in the browser console
  • (For User Stories only) Double-checked that all Acceptance Criteria are satisfied
  • Confirmed there are no new warnings on automated tests
  • Merged and published any dependent changes in downstream modules
  • Selected the correct base branch
  • Commented the code in hard-to-understand areas
  • Followed the code style guidelines of this project
  • Reviewed that the Files Changed in Github’s UI reflect my intended changes
  • Confirmed the pipeline checks are not failing

Review Checklist:

  • (For User Stories only) Tested in a preview or locally that all Acceptance Criteria are satisfied
  • Confirmed that changes follow the code style guidelines of this project

arabot-1 and others added 2 commits March 17, 2026 14:44
…page (#1047)

Signed-off-by: Milos Dzepina <milos@aragon.org>
(cherry picked from commit 73df695)
Copilot AI review requested due to automatic review settings March 21, 2026 20:02
@milosh86 milosh86 requested a review from a team as a code owner March 21, 2026 20:02
@milosh86 milosh86 closed this Mar 21, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This hotfix/release PR updates the DAO member details page to fetch plugin metadata with broader inclusion rules, while also preparing the repository for the 1.24.0 release via version/changelog updates and changeset housekeeping.

Changes:

  • Fetch DAO plugins on the member details page with includeSubPlugins (and explicitly includeLinkedAccounts) enabled.
  • Bump package version to 1.24.0 and add the corresponding CHANGELOG.md release section.
  • Remove consumed changesets and add a new changeset for the member-details plugin-fetch tweak; add .patches to .gitignore.

Reviewed changes

Copilot reviewed 10 out of 11 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
src/modules/governance/pages/daoMemberDetailsPage/daoMemberDetailsPageClient.tsx Expands plugin fetching to include sub-plugins (and linked-account plugins).
package.json Bumps app version to 1.24.0.
CHANGELOG.md Adds release notes for 1.24.0 (contains a new typo).
.gitignore Ignores .patches directory.
.changeset/member-details-include-sub-plugins.md Adds a new patch changeset for member details plugin fetching.
.changeset/*.md (removed) Removes changesets already applied into the 1.24.0 changelog.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

const bodyPlugins = useDaoPlugins({
daoId,
pluginAddress,
includeLinkedAccounts: true,
Copy link

Copilot AI Mar 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

includeLinkedAccounts: true is redundant here because daoUtils.getDaoPlugins already defaults includeLinkedAccounts to true when omitted. Consider removing this param (keep includeSubPlugins: true) to reduce noise and avoid implying there’s a non-default behavior being relied on.

Suggested change
includeLinkedAccounts: true,

Copilot uses AI. Check for mistakes.
includeLinkedAccounts: true,
includeSubPlugins: true,
});
const bodyPlugin = bodyPlugins?.[0]?.meta;
Copy link

Copilot AI Mar 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new behavior to include sub-plugins isn’t covered by existing tests for this component. Please add a test case where pluginAddress points to a plugin with isSubPlugin: true to ensure the member details page still resolves bodyPlugin correctly and doesn’t render null.

Suggested change
const bodyPlugin = bodyPlugins?.[0]?.meta;
const bodyPlugin =
bodyPlugins?.find((plugin) => plugin?.address === pluginAddress)?.meta ??
bodyPlugins?.[0]?.meta;

Copilot uses AI. Check for mistakes.

- [#1019](https://github.com/aragon/app/pull/1019) [`6f56480`](https://github.com/aragon/app/commit/6f5648088e8cfe427c236ece1252cb72aaa43bdf) Thanks [@milosh86](https://github.com/milosh86)! - Add lock and wrap onboarding dialogs

- [#1022](https://github.com/aragon/app/pull/1022) [`61725f5`](https://github.com/aragon/app/commit/61725f58469ab63a7c4fbc6d5e3029bce34e9a32) Thanks [@tyhonchik](https://github.com/tyhonchik)! - Implement DAO overrides functionality to hide unneded bodies
Copy link

Copilot AI Mar 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changelog entry contains a typo: “unneded” should be “unneeded”. Please correct it so release notes are clean and searchable.

Suggested change
- [#1022](https://github.com/aragon/app/pull/1022) [`61725f5`](https://github.com/aragon/app/commit/61725f58469ab63a7c4fbc6d5e3029bce34e9a32) Thanks [@tyhonchik](https://github.com/tyhonchik)! - Implement DAO overrides functionality to hide unneded bodies
- [#1022](https://github.com/aragon/app/pull/1022) [`61725f5`](https://github.com/aragon/app/commit/61725f58469ab63a7c4fbc6d5e3029bce34e9a32) Thanks [@tyhonchik](https://github.com/tyhonchik)! - Implement DAO overrides functionality to hide unneeded bodies

Copilot uses AI. Check for mistakes.
Comment on lines +1 to +5
---
"@aragon/app": patch
---

Include sub-plugins when fetching plugins on the member details page
Copy link

Copilot AI Mar 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR bumps package.json to 1.24.0 and adds a 1.24.0 section to CHANGELOG.md, but it also introduces a new changeset. Keeping a changeset in the repo means the next pnpm changeset version run will bump again (likely to 1.24.1) and the changelog won’t match what’s released as 1.24.0. Either apply this changeset into the current release notes (and remove the changeset) or adjust the version/changelog strategy so they stay consistent.

Suggested change
---
"@aragon/app": patch
---
Include sub-plugins when fetching plugins on the member details page

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants