fix(APP-517): Resolve cryptex voting escrow addresses dynamically#1066
Merged
thekidnamedkd merged 9 commits intomainfrom Apr 2, 2026
Merged
fix(APP-517): Resolve cryptex voting escrow addresses dynamically#1066thekidnamedkd merged 9 commits intomainfrom
thekidnamedkd merged 9 commits intomainfrom
Conversation
|
🚀 Preview Deployment: View Here |
|
E2E Smoke Results
|
milosh86
reviewed
Mar 31, 2026
Contributor
milosh86
left a comment
milosh86
left a comment
There was a problem hiding this comment.
Hey left a comment, I guess with added validation we don't need to change much as it adds safety if we miss the address
...nents/capitalDistributorCreateCampaignActionCreate/capitalDistributorCampaignPayoutField.tsx
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change removes Cryptex’s shared hardcoded voting escrow address and resolves the escrow address dynamically from the live token plugin metadata for Cryptex DAOs.
The capital distributor flow now passes daoId into the CAPITAL_DISTRIBUTOR_VOTING_ESCROW_ADDRESS slot, and Cryptex uses a centralized DAO-to-token-plugin mapping plus a hook-based slot resolver to read plugin.votingEscrow?.escrowAddress at runtime. This was needed because tokenRewards should not reuse the old shared Cryptex escrow constant, and the same dynamic pattern now works across the Cryptex DAO registrations.
It also adds the new tokenRewards Cryptex DAO entry and token-voting plugin mapping on Sepolia, and removes the temporary proposal-detail debugging logs that were added during investigation.
TOKEN VOTING REWARDS TEST PATH:
{{preview-url}}
/dao/ethereum-sepolia/0xF445edE111dD57Effc7aC9bcf8fC3dF1f60797Fa/Dependencies:
Type of Change
Developer Checklist:
Review Checklist: