Skip to content

fix(APP-4029): Update font-weight-normal to 400#419

Merged
cgero-eth merged 2 commits intomainfrom
APP-4029-update-font-weight
Mar 5, 2025
Merged

fix(APP-4029): Update font-weight-normal to 400#419
cgero-eth merged 2 commits intomainfrom
APP-4029-update-font-weight

Conversation

@milosh86
Copy link
Copy Markdown
Contributor

@milosh86 milosh86 commented Mar 4, 2025

Description

Update font-weight-normal to 400 to reflect the style definitions in Manrope Font.

Task: APP-4029

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • Manually smoke tested the functionality locally
  • Confirmed there are no new warnings or errors in the browser console
  • Made the corresponding changes to the documentation
  • Added tests that prove my fix is effective or that my feature works
  • Updated the CHANGELOG.md file after the [UPCOMING] title and before the latest version
  • (For User Stories only) Double-checked that all Acceptance Criteria are satisified
  • Confirmed there are no new warnings on automated tests
  • Selected the correct base branch
  • Commented the code in hard-to-understand areas
  • Followed the code style guidelines of this project
  • Reviewed that the files changed in GitHub’s UI reflect my intended changes
  • Confirmed the pipeline checks are not failing

Signed-off-by: Milos Dzepina <milos@aragon.org>
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Mar 4, 2025

CLA assistant check
All committers have signed the CLA.

@milosh86 milosh86 requested a review from a team March 4, 2025 11:00
@cgero-eth cgero-eth self-assigned this Mar 5, 2025
Copy link
Copy Markdown
Contributor

@cgero-eth cgero-eth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good, pipeline is failing though, probably because PR is missing the changes on the changelog file

@milosh86
Copy link
Copy Markdown
Contributor Author

milosh86 commented Mar 5, 2025

PR looks good, pipeline is failing though, probably because PR is missing the changes on the changelog file

@cgero-eth yeah, that's right I'll fix it! ... BTW, I realised that this change won't create any visual change, since correct font file was used (Manrope-Regular.ttf), only under the wrong weight (500 instead of 400). I think it's a good idea to merge this anyway to avoid confusion in the future.

Signed-off-by: Milos Dzepina <milos@aragon.org>
@cgero-eth
Copy link
Copy Markdown
Contributor

PR looks good, pipeline is failing though, probably because PR is missing the changes on the changelog file

@cgero-eth yeah, that's right I'll fix it! ... BTW, I realised that this change won't create any visual change, since correct font file was used (Manrope-Regular.ttf), only under the wrong weight (500 instead of 400). I think it's a good idea to merge this anyway to avoid confusion in the future.

@milosh86 Oh right, this won't change the actual font weight. Okay sounds good, we can still merge this to have things aligned 👌🏻

@cgero-eth cgero-eth merged commit 2fd93bb into main Mar 5, 2025
4 checks passed
@cgero-eth cgero-eth deleted the APP-4029-update-font-weight branch March 5, 2025 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants