Skip to content

feat(APP-3652): Add variant property to ToggleGroup component, support XS size on Avatar component#420

Merged
cgero-eth merged 4 commits intomainfrom
avatar-toggle-updates
Mar 11, 2025
Merged

feat(APP-3652): Add variant property to ToggleGroup component, support XS size on Avatar component#420
cgero-eth merged 4 commits intomainfrom
avatar-toggle-updates

Conversation

@cgero-eth
Copy link
Copy Markdown
Contributor

@cgero-eth cgero-eth commented Mar 10, 2025

Description

  • Add variant property to ToggleGroup component to support "space-between" spacing
  • Add XS size to Avatar core component

Task: APP-3652

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • Manually smoke tested the functionality locally
  • Confirmed there are no new warnings or errors in the browser console
  • Made the corresponding changes to the documentation
  • Added tests that prove my fix is effective or that my feature works
  • Updated the CHANGELOG.md file after the [UPCOMING] title and before the latest version
  • (For User Stories only) Double-checked that all Acceptance Criteria are satisified
  • Confirmed there are no new warnings on automated tests
  • Selected the correct base branch
  • Commented the code in hard-to-understand areas
  • Followed the code style guidelines of this project
  • Reviewed that the files changed in GitHub’s UI reflect my intended changes
  • Confirmed the pipeline checks are not failing

@cgero-eth cgero-eth changed the title WIP feat(APP-3652): Add variant property to ToggleGroup component, support XS size on Avatar component feat(APP-3652): Add variant property to ToggleGroup component, support XS size on Avatar component Mar 10, 2025
@cgero-eth cgero-eth requested a review from a team March 10, 2025 16:30
@cgero-eth cgero-eth force-pushed the avatar-toggle-updates branch from 5d6c0ee to c648ec0 Compare March 11, 2025 14:40
@cgero-eth cgero-eth force-pushed the avatar-toggle-updates branch from c648ec0 to 3e8c9e3 Compare March 11, 2025 14:42
Copy link
Copy Markdown
Contributor

@shan8851 shan8851 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cgero-eth cgero-eth merged commit a556902 into main Mar 11, 2025
4 checks passed
@cgero-eth cgero-eth deleted the avatar-toggle-updates branch March 11, 2025 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants