Skip to content

feat: Update DaoDataListItem component to support isExternal property#421

Merged
cgero-eth merged 3 commits intomainfrom
update-dao-list-item
Mar 11, 2025
Merged

feat: Update DaoDataListItem component to support isExternal property#421
cgero-eth merged 3 commits intomainfrom
update-dao-list-item

Conversation

@cgero-eth
Copy link
Copy Markdown
Contributor

Description

  • Update DaoDataListItem component to support isExternal property
  • Truncate address of DAO on item component

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • Manually smoke tested the functionality locally
  • Confirmed there are no new warnings or errors in the browser console
  • Made the corresponding changes to the documentation
  • Added tests that prove my fix is effective or that my feature works
  • Updated the CHANGELOG.md file after the [UPCOMING] title and before the latest version
  • (For User Stories only) Double-checked that all Acceptance Criteria are satisified
  • Confirmed there are no new warnings on automated tests
  • Selected the correct base branch
  • Commented the code in hard-to-understand areas
  • Followed the code style guidelines of this project
  • Reviewed that the files changed in GitHub’s UI reflect my intended changes
  • Confirmed the pipeline checks are not failing

@milosh86 milosh86 self-assigned this Mar 10, 2025
@milosh86 milosh86 self-requested a review March 10, 2025 18:41
milosh86
milosh86 previously approved these changes Mar 10, 2025
Copy link
Copy Markdown
Contributor

@milosh86 milosh86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 👍
I was actually planning to discuss this exact topic during tomorrow's sync 🙂

@cgero-eth cgero-eth force-pushed the update-dao-list-item branch from e9e1170 to 77d566b Compare March 11, 2025 14:40
@cgero-eth cgero-eth merged commit d8e6d75 into main Mar 11, 2025
3 checks passed
@cgero-eth cgero-eth deleted the update-dao-list-item branch March 11, 2025 14:41
Copy link
Copy Markdown
Contributor

@milosh86 milosh86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants