Conversation
Signed-off-by: Milos Dzepina <milos@aragon.org>
Signed-off-by: Milos Dzepina <milos@aragon.org>
There was a problem hiding this comment.
Pull request overview
This PR adjusts the proposal action UI logic so that raw calldata actions no longer expose the decoded view, and ensures decoder modes are selected consistently between decoded and raw views, while also updating lockfile metadata.
Changes:
- In
ProposalActionsItem, treatsRAW_CALLDATAactions as not supporting decoded view, initializes the active view accordingly, and refactors decoder mode selection into memoized helpers for decoded vs raw views. - In
ProposalActionsDecoder, documents why thedatafield is rendered as a hidden textarea in decoded view so it’s still registered in the form during EDIT mode. - In
pnpm-lock.yaml, updates metadata fortarpackage versions to include deprecation notices.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/modules/components/proposal/proposalActions/proposalActionsItem/proposalActionsItem.tsx | Disables decoded view for RAW_CALLDATA actions, adjusts initial view selection, and memoizes decoder mode selection for decoded and raw views. |
| src/modules/components/proposal/proposalActions/proposalActionsDecoder/proposalActionsDecoder.tsx | Adds an inline comment clarifying the hidden data field behavior in decoded view for form registration during EDIT mode. |
| pnpm-lock.yaml | Updates lockfile entries for tar packages with upstream deprecation messages; no runtime behavior changes. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/modules/components/proposal/proposalActions/proposalActionsItem/proposalActionsItem.tsx
Outdated
Show resolved
Hide resolved
src/modules/components/proposal/proposalActions/proposalActionsItem/proposalActionsItem.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Milos Dzepina <milos@aragon.org>
Signed-off-by: Milos Dzepina <milos@aragon.org>
Signed-off-by: Milos Dzepina <milos@aragon.org>
Signed-off-by: Milos Dzepina <milos@aragon.org>
Signed-off-by: Milos Dzepina <milos@aragon.org>
Signed-off-by: Milos Dzepina <milos@aragon.org>
Signed-off-by: Milos Dzepina <milos@aragon.org>
Signed-off-by: Milos Dzepina <milos@aragon.org>
Signed-off-by: Milos Dzepina <milos@aragon.org>
Signed-off-by: Milos Dzepina <milos@aragon.org>
Signed-off-by: Milos Dzepina <milos@aragon.org>
tyhonchik
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Task: APP-462
Type of change
Developer Checklist:
Review Checklist: