Skip to content

fix(APP-462): Disable decoded view for raw calldata actions and fix native transfer action rendering#642

Merged
milosh86 merged 13 commits intomainfrom
app-462-the-option-to-enter-raw-calldata-in-the-action-builder-is
Feb 4, 2026
Merged

fix(APP-462): Disable decoded view for raw calldata actions and fix native transfer action rendering#642
milosh86 merged 13 commits intomainfrom
app-462-the-option-to-enter-raw-calldata-in-the-action-builder-is

Conversation

@milosh86
Copy link
Contributor

@milosh86 milosh86 commented Feb 3, 2026

Description

  • Disable the decoded view for raw calldata action types to fix issue where raw data inputs are disabled.
  • Fix native transfer action decoding.

Task: APP-462

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Developer Checklist:

  • Manually smoke tested the functionality locally
  • Confirmed there are no new warnings or errors in the browser console
  • Made the corresponding changes to the documentation
  • Added tests that prove my fix is effective or that my feature works
  • (For User Stories only) Double-checked that all Acceptance Criteria are satisified
  • Confirmed there are no new warnings on automated tests
  • Selected the correct base branch
  • Commented the code in hard-to-understand areas
  • Followed the code style guidelines of this project
  • Reviewed that the files changed in GitHub’s UI reflect my intended changes
  • Confirmed the pipeline checks are not failing

Review Checklist:

  • Tested locally that all Acceptance Criteria or Expected Outcomes are satisfied
  • Confirmed that changes follow the code style guidelines of this project

Signed-off-by: Milos Dzepina <milos@aragon.org>
Signed-off-by: Milos Dzepina <milos@aragon.org>
Copilot AI review requested due to automatic review settings February 3, 2026 11:57
@linear
Copy link

linear bot commented Feb 3, 2026

@milosh86 milosh86 self-assigned this Feb 3, 2026
@milosh86 milosh86 changed the title fix(APP-462): Disable decoded view for raw calldata actions WIP fix(APP-462): Disable decoded view for raw calldata actions Feb 3, 2026
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts the proposal action UI logic so that raw calldata actions no longer expose the decoded view, and ensures decoder modes are selected consistently between decoded and raw views, while also updating lockfile metadata.

Changes:

  • In ProposalActionsItem, treats RAW_CALLDATA actions as not supporting decoded view, initializes the active view accordingly, and refactors decoder mode selection into memoized helpers for decoded vs raw views.
  • In ProposalActionsDecoder, documents why the data field is rendered as a hidden textarea in decoded view so it’s still registered in the form during EDIT mode.
  • In pnpm-lock.yaml, updates metadata for tar package versions to include deprecation notices.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.

File Description
src/modules/components/proposal/proposalActions/proposalActionsItem/proposalActionsItem.tsx Disables decoded view for RAW_CALLDATA actions, adjusts initial view selection, and memoizes decoder mode selection for decoded and raw views.
src/modules/components/proposal/proposalActions/proposalActionsDecoder/proposalActionsDecoder.tsx Adds an inline comment clarifying the hidden data field behavior in decoded view for form registration during EDIT mode.
pnpm-lock.yaml Updates lockfile entries for tar packages with upstream deprecation messages; no runtime behavior changes.
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: Milos Dzepina <milos@aragon.org>
Signed-off-by: Milos Dzepina <milos@aragon.org>
Signed-off-by: Milos Dzepina <milos@aragon.org>
Signed-off-by: Milos Dzepina <milos@aragon.org>
Signed-off-by: Milos Dzepina <milos@aragon.org>
Signed-off-by: Milos Dzepina <milos@aragon.org>
Signed-off-by: Milos Dzepina <milos@aragon.org>
Signed-off-by: Milos Dzepina <milos@aragon.org>
Signed-off-by: Milos Dzepina <milos@aragon.org>
Signed-off-by: Milos Dzepina <milos@aragon.org>
Signed-off-by: Milos Dzepina <milos@aragon.org>
@milosh86 milosh86 changed the title WIP fix(APP-462): Disable decoded view for raw calldata actions fix(APP-462): Disable decoded view for raw calldata actions Feb 4, 2026
@milosh86 milosh86 changed the title fix(APP-462): Disable decoded view for raw calldata actions fix(APP-462): Disable decoded view for raw calldata actions and fix native transfer action rendering Feb 4, 2026
@milosh86 milosh86 merged commit acd7421 into main Feb 4, 2026
8 of 9 checks passed
@milosh86 milosh86 deleted the app-462-the-option-to-enter-raw-calldata-in-the-action-builder-is branch February 4, 2026 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants