Skip to content

feat: remove nasty element #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rugbymauri wants to merge 2 commits into from
Closed

feat: remove nasty element #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d62379c
feat: remove nasty element
rugbymauri Feb 15, 2024
1f167a3
feat: add css for centring
rugbymauri Feb 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Resources/assets/styles/_tailwind.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@
@apply fixed z-50 duration-300 ease-in-out transform inset-0 overflow-y-auto;

&__overlay {
@apply relative flex min-h-screen text-center md:block md:px-4 lg:px-8 text-[0];
@apply relative flex flex-col justify-center min-h-screen text-center md:block md:px-4 lg:px-8 text-[0];
}

&__backdrop {
Expand Down
3 changes: 0 additions & 3 deletions src/Resources/views/includes/_action.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,9 +191,6 @@
{{ stimulus_action('araise/core-bundle/modal-form', 'close', 'click') | stimulus_action('araise/core-bundle/modal-form', 'close', 'keydown.esc@window') }}
></div>

{# This element is to trick the browser into centering the modal contents. #}
<span class="hidden md:inline-block md:align-middle md:h-screen" aria-hidden="true">&#8203;</span>

<div class="whatwedo-crud-modal__wrapper whatwedo-utility-modal__wrapper">
<div class="whatwedo-utility-modal__wrapper-inner">
<button
Expand Down