Skip to content

Conversation

@nerpaula
Copy link
Contributor

@nerpaula nerpaula commented Jan 10, 2024

Description

See arangodb/arangodb#20374

Upstream PRs

  • 3.10:
  • 3.11:
  • 3.12: arangodb/enterprise-preview:devel-nightly

@arangodb-docs-automation
Copy link
Contributor

Deploy Preview Available Via
https://deploy-preview-420--docs-hugo.netlify.app

@cla-bot cla-bot bot added the cla-signed label Jan 10, 2024
@nerpaula
Copy link
Contributor Author

/generate

@nerpaula nerpaula self-assigned this Jan 10, 2024
@nerpaula nerpaula added this to the 3.12 milestone Jan 10, 2024
@nerpaula nerpaula marked this pull request as ready for review January 10, 2024 06:01
@nerpaula nerpaula requested a review from Simran-B January 10, 2024 06:02
@nerpaula
Copy link
Contributor Author

/commit

@cla-bot cla-bot bot removed the cla-signed label Jan 10, 2024
@arangodb arangodb deleted a comment from cla-bot bot Jan 10, 2024
@nerpaula nerpaula requested a review from Simran-B January 10, 2024 10:59
- `autoincrement`
- `traditional`
responses:
'200':
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine in Swagger UI and swagger-cli validated it as correct, so it looks like the toolchain is not able to render a construct like this

image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With added example value:
image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@cla-bot
Copy link

cla-bot bot commented Jan 12, 2024

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: CircleCI Job.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@Simran-B
Copy link
Contributor

/generate

@cla-bot
Copy link

cla-bot bot commented Jan 15, 2024

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: CircleCI Job.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

content:
application/json:
schema:
type: array
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually incorrect (my bad), it's an object at the top-level, and an array under the keyGenerators property. The toolchain basically doesn't seem to support arrays, which is a problem here but also for a few other endpoints (and more in the future if we move from full-text to structural descriptions)

@cla-bot
Copy link

cla-bot bot commented Jan 15, 2024

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: CircleCI Job.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@cla-bot
Copy link

cla-bot bot commented Jan 15, 2024

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: CircleCI Job.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@cla-bot
Copy link

cla-bot bot commented Jan 15, 2024

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: CircleCI Job.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@Simran-B
Copy link
Contributor

We can merge with the latest changes:

image

- `autoincrement`
- `traditional`
responses:
'200':
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With added example value:
image

@nerpaula nerpaula merged commit 27e2448 into main Jan 15, 2024
@nerpaula nerpaula deleted the api-key-generators branch January 15, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants