Skip to content

DOC-684 | Default server language changed #523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 3, 2024
Merged

DOC-684 | Default server language changed #523

merged 1 commit into from
May 3, 2024

Conversation

@Simran-B
Copy link
Contributor

@Simran-B Simran-B commented May 3, 2024 •
edited
Loading

Description

https://arangodb.atlassian.net/browse/DOC-684

Upstream PRs

  • 3.10:
  • 3.11:
  • 3.12:
  • 3.13:

@arangodb-docs-automation
Copy link
Contributor

arangodb-docs-automation bot commented May 3, 2024

Deploy Preview Available Via
https://deploy-preview-523--docs-hugo.netlify.app

@cla-bot cla-bot bot added the cla-signed label May 3, 2024
@Simran-B Simran-B requested a review from KVS85 May 3, 2024 14:51
@Simran-B Simran-B self-assigned this May 3, 2024
@Simran-B Simran-B added this to the 3.12 milestone May 3, 2024
@Simran-B Simran-B requested a review from neunhoef May 3, 2024 14:51
jsteemann
jsteemann approved these changes May 3, 2024
View reviewed changes
Copy link
Contributor

@jsteemann jsteemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Simran-B
Copy link
Contributor Author

Simran-B commented May 3, 2024

If no language startup option is set and if the LANG env var is set to an empty string or invalid, we seem to write {"default":""} to the LANGUAGE file, and my understanding is that ICU defaults to en_US_POSIX in this case. If LANG is not present, we seem to write {"default":"en_US_POSIX"}. The effective locale/language appears to be the same, and I was told that upgrading does not change the language/sorting behavior even if the persisted language is "", so I don't see a reason to document this detail.

@Simran-B Simran-B merged commit 7d47787 into main May 3, 2024
@Simran-B Simran-B deleted the DOC-684 branch May 3, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KVS85 KVS85 KVS85 approved these changes

@neunhoef neunhoef Awaiting requested review from neunhoef

+1 more reviewer

@jsteemann jsteemann jsteemann approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Simran-B Simran-B

Labels

cla-signed

Projects

None yet

Milestone

3.12

Development

Successfully merging this pull request may close these issues.

4 participants

@Simran-B @jsteemann @KVS85