refactor: fix critical code inconsistencies (types, protocols, logging) #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nikolay-e
commented
Jan 3, 2026
nikolay-e
commented
- Replace ABC with Protocol for structural typing (cache, similarity, secrets)
- Add GraphValidationError for workflow validation errors
- Fix Any types to specific types (logger, base_dir, response_cache)
- Convert f-strings to %-formatting in logging for deferred evaluation
- Replace logger.error with logger.exception in except blocks
- Convert relative imports to absolute in tournament.py
- Standardize logger naming to name
- Replace ABC with Protocol for structural typing (cache, similarity, secrets) - Add GraphValidationError for workflow validation errors - Fix Any types to specific types (logger, base_dir, response_cache) - Convert f-strings to %-formatting in logging for deferred evaluation - Replace logger.error with logger.exception in except blocks - Convert relative imports to absolute in tournament.py - Standardize logger naming to __name__
Diff Context
Use this context for AI code review with ChatGPT, Claude, or other LLMs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.