CI: add rpm build workflow #1244
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junghans
commented
Apr 22, 2025
junghans
commented
Apr 22, 2025
Contributor
|
@junghans Does not seem like it works unless I'm missing something. |
junghans
force-pushed
the
rpmbuild
branch
2 times, most recently
from
db41882 to
8d70ca1
Compare
Contributor
Author
|
Contributor
|
@junghans Is it possible to run the CI based on the current branch? So that if I push here, it runs the change and not 2.0. Also, is there a way to speed it up, it seems to take 2+ hours? |
Contributor
Author
@aprokop it makes a tarball out of the current checkout, it is just the tarball is always named But maybe the easiest would to trying to just build it with same flags and CMake options: |
Contributor
|
So it seems that the following change makes it pass: --- a/src/spatial/detail/ArborX_ExpandHalfToFull.hpp
+++ b/src/spatial/detail/ArborX_ExpandHalfToFull.hpp
@@ -50,19 +50,13 @@ void expandHalfToFull(ExecutionSpace const &space, Offsets &offsets,
"ArborX::Experimental::HalfToFull::counts");
Kokkos::parallel_for(
"ArborX::Experimental::HalfToFull::rewrite",
- Kokkos::TeamPolicy(space, n, Kokkos::AUTO, 1),
- KOKKOS_LAMBDA(
- typename Kokkos::TeamPolicy<ExecutionSpace>::member_type const
- &member) {
- auto const i = member.league_rank();
- auto const first = offsets_orig(i);
- auto const last = offsets_orig(i + 1);
- Kokkos::parallel_for(
- Kokkos::TeamVectorRange(member, last - first), [&](int j) {
- int const k = indices_orig(first + j);
- indices(Kokkos::atomic_fetch_inc(&counts(i))) = k;
- indices(Kokkos::atomic_fetch_inc(&counts(k))) = i;
- });
+ Kokkos::RangePolicy(space, 0, n), KOKKOS_LAMBDA(int i) {
+ for (int j = offsets_orig(i); j < offsets_orig(i + 1); ++j)
+ {
+ int const k = indices_orig(j);
+ indices(Kokkos::atomic_fetch_inc(&counts(i))) = k;
+ indices(Kokkos::atomic_fetch_inc(&counts(k))) = i;
+ }
});
Kokkos::Profiling::popRegion();
}I don't understand why. Both codes seem valid to me. It seems to only affect |
Contributor
Author
|
I am not sure either, but maybe @dalg24 knows.... |
Contributor
Author
|
Either way, I patched that in and rebuild: https://koji.fedoraproject.org/koji/taskinfo?taskID=131982908 |
Contributor
|
Hmm, the latest patch failed in a different place: So, it seems, the failures are intermittent. I really need to be able to run things in a loop to properly debug this. |
Contributor
Author
|
The |
| auto const last = offsets_orig(i + 1); | ||
| Kokkos::parallel_for( | ||
| Kokkos::TeamVectorRange(member, last - first), [&](int j) { | ||
| Kokkos::TeamThreadRange(member, last - first), [&](int j) { |
Collaborator
There was a problem hiding this comment.
TeamVectorRange looks more correct here (so that it would also work with vector_length > 1).
Contributor
Author
|
@aprokop let me know if you have a patch set I should test on Fedora again. |
Contributor
Author
|
@aprokop any update on this, anything I can help with. |
Contributor
|
@junghans I think I'm essentially stuck here. None of it makes any sense to me. I will try to add more printouts and see if I can track it some more. I wonder if it is some optimizations again, and the issue would disappear with "-O0". |
Contributor
|
Either the failure is intermittent (which it could be), or it is similar to #1186. |
Contributor
Author
|
@dalg24 any ideas? |
junghans
force-pushed
the
rpmbuild
branch
3 times, most recently
from
009c4a1 to
30529a5
Compare
Contributor
Author
|
@aprokop I gave this a fresh start, similar to what we did in |
Contributor
|
I looked at the code again, and still no wiser. Need to be able to access arm64 without cross-compiling. |
Contributor
Author
|
On apple-silicon mac with docker you could use the following dockerfile: FROM registry.fedoraproject.org/fedora:latest
RUN dnf install -y fedpkg wget
RUN wget https://github.com/junghans/ArborX/archive/refs/heads/rpmbuild.zip
RUN unzip rpmbuild.zip
RUN mv ArborX-rpmbuild ArborX
RUN tar -cvzf ArborX-9999.tar.gz ArborX/
RUN mkdir ArborX.rpm
RUN mv ArborX-9999.tar.gz ArborX.rpm
WORKDIR ArborX.rpm
RUN wget https://github.com/junghans/ArborX/raw/refs/heads/rpmbuild/.github/workflows/ArborX.spec
RUN dnf -y builddep ArborX.spec
RUN fedpkg --verbose --debug local |
Contributor
Thank you. I need to figure out how to bypass the proxies on my work mac, as it's running into |
Contributor
Author
|
You could add a line like |
Contributor
I think I wrongly attributed the problem to proxy. It is the certificate replacement issue, where our deep inspection thingie replaces certificates. I slightly changed the recipe by this tweak: |
Contributor
|
Running into issue on the last step: |
Contributor
Author
|
Ok, I not sure how that happened, but I was able to reproduce it on one of my machines, try with these 3 lines at the end: |
Contributor
|
May still be a certificate problem |
Contributor
Author
|
How about ...
RUN dnf -y builddep ArborX.spec
RUN rpmbuild --define "_sourcedir $(pwd)" -ba ArborX.spec |
Contributor
That works. I'm trying to build it. I'm getting warnings like this Is it possible to go into the build directory and try to compile manually? If I try |
Contributor
Author
|
Something like: |
Contributor
|
Getting some errors when building inside the container But the two tests that fail in this PR were built ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #1241