-
Notifications
You must be signed in to change notification settings - Fork 45
Prefer Kokkos::Experimental::sort_by_key() and drop rocThrust/oneDPL dependencies
#1302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
I am not sure how much we care about the |
|
|
The |
|
I tried the same in #1191. I remember seeing some performance regression. You would need to run a lot of experiments to make sure there's none. |
Should I assume you tested with the performance fix on random access iterators kokkos/kokkos#7304 ? |
Don't know. Regardless, we depend on Kokkos 4.5, and that patch appeared only in 4.6.01. |
Kokkos 5.0 is a couple weeks out. Are we still committed to only supporting the last 2 Kokkos minor releases or is that something you were wanting to change. |
I had bad experience of keeping with the last two releases, as propagating the new features into the projects that depend on Trilinos is so problematic. |
|
Trilinos 16.2 was released with Kokkos 4.7.1. |
Defer to Kokkos and get rid of all the churn, both on the cmake-side to handle dependencies and the code path specializations.
I kept
Details::KokkosExt::sortByKey()because I don't think Kokkos pushes a profiling region.