Skip to content

[femutils] Minor refactoring of classes BSRFormat and BSRMatrix#310

Merged
grospelliergilles merged 1 commit intomainfrom
dev/gg-refactor-bsrformat-class
Sep 6, 2025
Merged

[femutils] Minor refactoring of classes BSRFormat and BSRMatrix#310
grospelliergilles merged 1 commit intomainfrom
dev/gg-refactor-bsrformat-class

Conversation

@grospelliergilles
Copy link
Member

@grospelliergilles grospelliergilles commented Sep 6, 2025

Make big methods of BSRFormat and BSRMatrix non inline.

@grospelliergilles grospelliergilles self-assigned this Sep 6, 2025
@grospelliergilles grospelliergilles added the refactor Code refactor label Sep 6, 2025
@codecov
Copy link

codecov bot commented Sep 6, 2025

Codecov Report

❌ Patch coverage is 91.79104% with 33 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.01%. Comparing base (50a0cec) to head (3d0252b).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
femutils/BSRFormat.cc 90.54% 23 Missing and 8 partials ⚠️
femutils/BSRFormat.h 97.29% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #310      +/-   ##
==========================================
+ Coverage   69.00%   69.01%   +0.01%     
==========================================
  Files         112      113       +1     
  Lines       14265    14276      +11     
  Branches     1944     1953       +9     
==========================================
+ Hits         9843     9853      +10     
- Misses       3959     3977      +18     
+ Partials      463      446      -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@grospelliergilles grospelliergilles merged commit 1560daa into main Sep 6, 2025
5 checks passed
@mohd-afeef-badri mohd-afeef-badri deleted the dev/gg-refactor-bsrformat-class branch September 25, 2025 19:19
jojoasticot pushed a commit to jojoasticot/arcanefem that referenced this pull request Nov 27, 2025
…factor-bsrformat-class

[femutils] Minor refactoring of classes `BSRFormat` and `BSRMatrix`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor Code refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant