Skip to content

Comments

[femutils] separate Matrix and RHS transformation from solving#314

Merged
grospelliergilles merged 4 commits intomainfrom
dev/gg-seperate-matrix-and-rhs-transformation-from-solve
Sep 8, 2025
Merged

[femutils] separate Matrix and RHS transformation from solving#314
grospelliergilles merged 4 commits intomainfrom
dev/gg-seperate-matrix-and-rhs-transformation-from-solve

Conversation

@grospelliergilles
Copy link
Member

Add two specific methods to apply linear system transformation:

  • DoFLinearSystem::applyMatrixTransformation(); to do the Matrix transformation
  • DoFLinearSystem::applyRHSTransformation() to do the RHS transformation

Rename DoFLinearSystem::solve() to DoFLinearSystem::::applyLinearSystemTransformationAndSolve() and add
DoFLinearSystem::solve() to don only the solving without modifying the matrix or the RHS. This method solve() may now be called several times.

…ation, RHS transformation and only the solving of the linear system.
The first time we call 'applyLinearSystemTransformationAndSolve()' and
the second time we only call 'solve()'. This will allow us to test if
the implementation used handles calling the solving several times.
@grospelliergilles grospelliergilles self-assigned this Sep 8, 2025
@grospelliergilles grospelliergilles added enhancement New feature or request refactor Code refactor labels Sep 8, 2025
@codecov
Copy link

codecov bot commented Sep 8, 2025

Codecov Report

❌ Patch coverage is 95.83333% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.13%. Comparing base (6d575b2) to head (1e0d2d9).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
femutils/AlephDoFLinearSystem.cc 93.54% 1 Missing and 1 partial ⚠️
modules/passmonl/NLDynamicModule.cc 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #314      +/-   ##
==========================================
+ Coverage   69.08%   69.13%   +0.04%     
==========================================
  Files         113      113              
  Lines       14308    14336      +28     
  Branches     1957     1960       +3     
==========================================
+ Hits         9885     9911      +26     
- Misses       3977     3978       +1     
- Partials      446      447       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@grospelliergilles grospelliergilles merged commit e97e5cd into main Sep 8, 2025
17 checks passed
@mohd-afeef-badri mohd-afeef-badri deleted the dev/gg-seperate-matrix-and-rhs-transformation-from-solve branch September 25, 2025 19:19
jojoasticot pushed a commit to jojoasticot/arcanefem that referenced this pull request Nov 27, 2025
…perate-matrix-and-rhs-transformation-from-solve

[femutils] separate Matrix and RHS transformation from solving
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request refactor Code refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant