[femutils] separate Matrix and RHS transformation from solving#314
Merged
grospelliergilles merged 4 commits intomainfrom Sep 8, 2025
Merged
Conversation
…ation, RHS transformation and only the solving of the linear system.
The first time we call 'applyLinearSystemTransformationAndSolve()' and the second time we only call 'solve()'. This will allow us to test if the implementation used handles calling the solving several times.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #314 +/- ##
==========================================
+ Coverage 69.08% 69.13% +0.04%
==========================================
Files 113 113
Lines 14308 14336 +28
Branches 1957 1960 +3
==========================================
+ Hits 9885 9911 +26
- Misses 3977 3978 +1
- Partials 446 447 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jojoasticot
pushed a commit
to jojoasticot/arcanefem
that referenced
this pull request
Nov 27, 2025
…perate-matrix-and-rhs-transformation-from-solve [femutils] separate Matrix and RHS transformation from solving
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add two specific methods to apply linear system transformation:
DoFLinearSystem::applyMatrixTransformation();to do the Matrix transformationDoFLinearSystem::applyRHSTransformation()to do the RHS transformationRename
DoFLinearSystem::solve()toDoFLinearSystem::::applyLinearSystemTransformationAndSolve()and addDoFLinearSystem::solve()to don only the solving without modifying the matrix or the RHS. This methodsolve()may now be called several times.