Skip to content

Conversation

@ZR233
Copy link
Contributor

@ZR233 ZR233 commented Nov 28, 2025

This pull request primarily refactors and improves code formatting, error handling, and argument parsing in the xtask utility, while also introducing new functionality for managing local devspace dependencies. The changes enhance code readability, maintain consistent error messages, and add a new subcommand for devspace management.

Refactoring and Code Formatting:

  • Reformatted long lines and improved readability in xtask/src/image.rs, including argument parsing and print statements for image listing and downloading. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]
  • Reordered imports for consistency and clarity in xtask/src/image.rs.

Error Handling Improvements:

  • Standardized error formatting using {e} and {percent} in error messages and progress output across xtask/src/image.rs and xtask/src/tbuld.rs. [1] [2]

Dependency and Configuration Updates:

  • Moved the ostool dependency in xtask/Cargo.toml for better organization and removed unnecessary blank lines. [1] [2]
  • Removed commented-out patch configuration in .cargo/config.toml for cleanup.
  • Minor syntax fix in platform/x86-qemu-q35/src/mp.rs for FFI declaration.

New Feature: Devspace Management:

  • Added a new Devspace subcommand to xtask with start and stop actions, including argument parsing and command dispatch in xtask/src/main.rs. [1] [2] [3] [4]

These changes collectively improve the maintainability and usability of the xtask utility.

- Introduced `devspace` module for managing local development dependencies.
- Added `start` and `stop` commands to the `devspace` functionality.
- Updated `.cargo/config.toml` to include an alias for `xtask`.
- Modified `.gitignore` to exclude `.devspace/` directory.
- Added new dependencies in `Cargo.lock` and `xtask/Cargo.toml`.
- Refactored `xtask/src/cargo.rs` and `xtask/src/image.rs` for improved code structure and readability.
- Cleaned up unnecessary whitespace in various files.
@ZR233 ZR233 requested a review from ZCShou November 28, 2025 05:21
@ZR233 ZR233 merged commit 90b1e19 into master Nov 28, 2025
5 of 12 checks passed
@ZR233 ZR233 deleted the rewrite3 branch November 28, 2025 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants