feat: Add .code64 directive to naked assembly for VMX entry and exit#22
Closed
feat: Add .code64 directive to naked assembly for VMX entry and exit#22
.code64 directive to naked assembly for VMX entry and exit#22Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a compilation error related to assembly code generation by adding .code64 directives to naked assembly blocks in VMX entry and exit functions. The error occurred because .code32 directives elsewhere in the codebase were affecting subsequent code compilation, causing the assembler to reject 64-bit register usage.
- Added
.code64directive to VMX entry macro to ensure 64-bit mode assembly - Added
.code64directive to VMX exit function to ensure 64-bit mode assembly
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
axplat中 .code32 代码可能影响到了后续代码,编译时产生
依赖版本问题,需要先通过:
arceos-hypervisor/axdevice_base#40
arceos-hypervisor/x86_vlapic#6