Add assertion in BitmapPageAllocator::init#10
Conversation
Co-authored-by: equation314 <11389231+equation314@users.noreply.github.com>
…ddresses Co-authored-by: equation314 <11389231+equation314@users.noreply.github.com>
Co-authored-by: equation314 <11389231+equation314@users.noreply.github.com>
Co-authored-by: equation314 <11389231+equation314@users.noreply.github.com>
Co-authored-by: equation314 <11389231+equation314@users.noreply.github.com>
|
@copilot Panic if |
Per review feedback, instead of silently falling back to reduced alignment support, now explicitly panic with a clear error message when the bitmap capacity is insufficient for the requested allocation. This provides better error reporting and makes the limitation explicit rather than degrading functionality silently. Added test to verify panic behavior when capacity is exceeded. Co-authored-by: equation314 <11389231+equation314@users.noreply.github.com>
Changed to panic with a clear error message when bitmap capacity is exceeded. Added test Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
|
@copilot Please check if |
Co-authored-by: AsakuraMizu <17076564+AsakuraMizu@users.noreply.github.com>
Done in 0e9969b. I verified those two tests were redundant with Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
BitmapPageAllocator::initpanics when initialized with a non-zero start address at maximum capacity (256MB default). The base address is always aligned down to 1GB boundaries, creating a gap that exhausts bitmap capacity before the requested region fits.Changes
test_init_capacity_exceededto verify the new panic pathtest_init_nonzero_start_addressandtest_init_with_1gb_aligned_startbecause their behavior is already covered by existingtest_bitmap_page_allocator_size_2gExample
The fix ensures users get immediate, informative feedback when their configuration exceeds bitmap capacity, rather than encountering an obscure assertion failure from the underlying bitmap allocator.
Original prompt
BitmapPageAllocator::initassertion fails in default feature settings #9✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.