fix(vsock): defer receiving and update credit #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… receiving creditrequest events 1.Increase the ring buffer size for vsock connections. 2.When a VsockEventType::Received event is polled, the recv operation is delegated to the upper layer. 3.After recv, actively trigger a CreditUpdate event. 4.Remove unused parameter 'buf'.
AsakuraMizu
approved these changes
Jan 1, 2026
AsakuraMizu
changed the title
There was a problem hiding this comment.
Pull request overview
This PR fixes an issue where vsock connections couldn't send or receive data due to missing creditrequest events. The solution changes the event handling architecture to defer data reading to the upper layer and actively trigger credit updates after recv operations.
Key changes:
- Increases ring buffer size from default to 32KB for vsock connections
- Modifies event handling to notify upper layer of received data without reading it immediately
- Adds explicit credit update triggers after recv operations
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| axdriver_vsock/src/lib.rs | Removes unused buf parameter from poll_event trait method signature |
| axdriver_virtio/src/socket.rs | Increases buffer capacity to 32KB, adds credit update after recv, defers data reading to upper layer in event handling |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.Increase the ring buffer size for vsock connections.
2.When a VsockEventType::Received event is polled, the recv operation is delegated to the upper layer.
3.After recv, actively trigger a CreditUpdate event.
4.Remove unused parameter 'buf'.