Skip to content

fix(la64): set PTEFlags::D with MappingFlags::WRITE #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 9, 2025
Merged

fix(la64): set PTEFlags::D with MappingFlags::WRITE #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e537bd4
fix(la64): set PTEFlags::D with MappingFlags::WRITE
AsakuraMizu Jul 17, 2025
57608a4
fix: doc_auto_cfg
AsakuraMizu Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions page_table_entry/src/arch/loongarch64.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ impl From<MappingFlags> for PTEFlags {
ret |= Self::NR;
}
if f.contains(MappingFlags::WRITE) {
ret |= Self::W;
ret |= Self::W | Self::D;
}
if !f.contains(MappingFlags::EXECUTE) {
ret |= Self::NX;
Expand Down Expand Up @@ -134,7 +134,7 @@ impl LA64PTE {

impl GenericPTE for LA64PTE {
fn new_page(paddr: PhysAddr, flags: MappingFlags, is_huge: bool) -> Self {
let mut flags = PTEFlags::from(flags) | PTEFlags::D;
let mut flags = PTEFlags::from(flags);
if is_huge {
flags |= PTEFlags::GH;
}
Expand All @@ -153,7 +153,7 @@ impl GenericPTE for LA64PTE {
self.0 = (self.0 & !Self::PHYS_ADDR_MASK) | (paddr.as_usize() as u64 & Self::PHYS_ADDR_MASK)
}
fn set_flags(&mut self, flags: MappingFlags, is_huge: bool) {
let mut flags = PTEFlags::from(flags) | PTEFlags::D;
let mut flags = PTEFlags::from(flags);
if is_huge {
flags |= PTEFlags::GH;
}
Expand Down
2 changes: 1 addition & 1 deletion page_table_entry/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#![cfg_attr(not(test), no_std)]
#![cfg_attr(doc, feature(doc_auto_cfg))]
#![cfg_attr(doc, feature(doc_cfg))]
#![doc = include_str!("../README.md")]

mod arch;
Expand Down
2 changes: 1 addition & 1 deletion page_table_multiarch/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#![cfg_attr(not(test), no_std)]
#![cfg_attr(doc, feature(doc_auto_cfg))]
#![cfg_attr(doc, feature(doc_cfg))]
#![doc = include_str!("../README.md")]

#[macro_use]
Expand Down