Skip to content

Update Node.js version to match Cloudflare v3 build system default runtime#251

Merged
brianzelip merged 1 commit intomainfrom
update-node-version-to-match-cloudflare-v3-build-image-default-runtime
Aug 19, 2025
Merged

Update Node.js version to match Cloudflare v3 build system default runtime#251
brianzelip merged 1 commit intomainfrom
update-node-version-to-match-cloudflare-v3-build-image-default-runtime

Conversation

@brianzelip
Copy link
Collaborator

This PR updates the Node.js version to match the default Node runtime used by the latest Cloudflare v3 build system. The site was set to use the v3 system via the Cloudflare dashboard just before this PR.

@brianzelip brianzelip requested a review from crugas August 19, 2025 17:04
@brianzelip brianzelip force-pushed the update-node-version-to-match-cloudflare-v3-build-image-default-runtime branch from e7081e2 to 3b525d5 Compare August 19, 2025 17:07
Copy link
Contributor

@crugas crugas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Just out of curiosity, is there a way to determine how updating dependency versions affect the website? I'm thinking of a scenario where an updated dependency introduces unexpected behavior to the site. Perhaps a test space for techdocs for major dependency updates?

@cloudflare-workers-and-pages
Copy link

Deploying archivesspace-tech-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3b525d5
Status: ✅  Deploy successful!
Preview URL: https://ba5daaee.archivesspace-tech-docs.pages.dev
Branch Preview URL: https://update-node-version-to-match.archivesspace-tech-docs.pages.dev

View logs

@brianzelip
Copy link
Collaborator Author

@crugas yes there are a couple ways. This PR environment itself tests it...that's what CI is for. See the "All checks have passed" section herein. The "Cloudflare Pages" check shows a status of "Deployed successfully". That is one such that checks whether or not deployment breaks with the proposed changes.

Testing locally is another way, etc.

@brianzelip brianzelip merged commit 2b40c0d into main Aug 19, 2025
4 checks passed
@brianzelip brianzelip deleted the update-node-version-to-match-cloudflare-v3-build-image-default-runtime branch August 19, 2025 17:11
@crugas
Copy link
Contributor

crugas commented Aug 19, 2025

@crugas yes there are a couple ways. This PR environment itself tests it...that's what CI is for. See the "All checks have passed" section herein. The "Cloudflare Pages" check shows a status of "Deployed successfully". That is one such that checks whether or not deployment breaks with the proposed changes.

Testing locally is another way, etc.

Ah cool! I wasn't sure what the tests were testing for, so it's good to know that the Cloudfare Pages test deploys a dev version with the updated dependency and sees if it's breaking or not. I take it users could also go clicking around on that dev site (https://update-node-version-to-match.archivesspace-tech-docs.pages.dev/) if they really wanted to test things out themselves too. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants