-
Notifications
You must be signed in to change notification settings - Fork 680
h2t: protect host cfg #4090
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
+10
−3
Closed
h2t: protect host cfg #4090
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,9 @@ | ||
| import atexit | ||
| import re | ||
| from pathlib import Path | ||
| from shutil import copy2 | ||
|
|
||
| from ..general import running_from_host | ||
| from ..models.packages import Repository | ||
|
|
||
|
|
||
|
|
@@ -46,9 +48,14 @@ def apply(self) -> None: | |
| if row + 1 < len(content) and content[row + 1].lstrip().startswith('#'): | ||
| content[row + 1] = re.sub(r'^#\s*', '', content[row + 1]) | ||
|
|
||
| # Write the modified content back to the file | ||
| with open(self._config_path, 'w') as f: | ||
| f.writelines(content) | ||
| # Apply temp using backup then revert on exit handler | ||
| if running_from_host(): | ||
| temp_copy = self._config_path.with_suffix('.bak') | ||
| copy2(self._config_path, temp_copy) | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Every time you're running this apply function you will copy the pacman.conf file, which means if you run it 2 times, it will override the first backup file. |
||
| atexit.register(lambda: copy2(temp_copy, self._config_path)) | ||
| else: # Apply directly | ||
| with open(self._config_path, 'w') as f: | ||
| f.writelines(content) | ||
|
|
||
| def persist(self) -> None: | ||
| if self._repositories and self._config_remote_path: | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.