Skip to content

Replace pip with uv #579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Replace pip with uv #579

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
ef1ed5c
Replace `pip` with `uv`
benmezger Aug 30, 2025
456eca8
Migrate Ruff settings
benmezger Aug 30, 2025
ee8b5ea
Refactor Github action to use Ruff
benmezger Aug 30, 2025
985c4f5
Apply ruff check changes
benmezger Aug 30, 2025
617ffad
Ensure Makefile runs with UV
benmezger Aug 30, 2025
cf73476
Add SMTP group
benmezger Aug 30, 2025
56e3f32
Update README
benmezger Aug 30, 2025
990f824
Update Gitlab CI configuration
benmezger Aug 30, 2025
6634c9b
Remove `.python-version` and use toml instead
benmezger Aug 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions main/storage.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,9 @@
import cssmin
import jsmin
from django.contrib.staticfiles.storage import ManifestStaticFilesStorage
from django.core.files.base import ContentFile
from django.utils.encoding import smart_str

import cssmin
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ruff check . is happy for me, why is the uv used ruff not?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could it be that you are running a different version of ruff? We are installing the latest in the CI:

archweb/.github/workflows/main.yml

Line 19 in 59229f2

pip install -r requirements.txt && pip install -r requirements_test.txt && pip install ruff

This is one of the benefits of managing dependencies with uv, since we are now locking a particular version and making sure we always run that version, without having a separate requirements for each group.



class MinifiedStaticFilesStorage(ManifestStaticFilesStorage):
"""
Expand Down
2 changes: 1 addition & 1 deletion mirrors/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ def dictfetchall(cursor):
"Returns all rows from a cursor as a dict."
desc = cursor.description
return [
dict(zip([col[0] for col in desc], row))
dict(zip([col[0] for col in desc], row, strict=False))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be a place where strict=True seems fine to use.

for row in cursor.fetchall()
]

Expand Down